Repository navigation
fix(ci): move the remaining caller inputs out of run blocks - #404
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
The changes are correct. Word splitting still works where it has to: arg lists and script-runner like pnpm run are left unquoted, single values are quoted, and the PowerShell ${env:BIN_NAME} form is right. The only remaining ${{ }} in these run blocks are matrix values, runner.temp and step outputs, none of which a caller controls.
Nit: this is outside the diff, but reusable-release-rust.yml still has cargo publish --token ${{ secrets.CARGO_REGISTRY_TOKEN }} in a run block. You could move it to env: CARGO_REGISTRY_TOKEN: ... and drop --token, since cargo reads that variable on its own.
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #401
Same treatment as #273: every caller input and step output that was expanded into a
run:block in the reusables and the two composite actions is now passed throughenv:and referenced as a shell variable.*-argsinputs keep their word splitting (unquoted), matching the rust reusable.zizmor
template-injectionfindings on.github: 42 before, 0 after. All run blocks still passbash -n. The repo has no test setup.