Fix Windows update file lock - #10
Merged
Merged
Conversation
FaulMit
marked this pull request as ready for review
August 2, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.downloadfilesRoot cause
DownloadVerifiedAsyncopened the temporary package withFileShare.Noneand calledFile.Movebefore the stream left itsawait usingscope. Windows therefore rejected Captail's own rename withERROR_SHARING_VIOLATION. The invalid-cache path had the same lifetime issue beforeFile.Delete.User impact
One-click updates work normally starting with 0.1.5. Users already running 0.1.3 or 0.1.4 must install 0.1.5 manually once because the faulty updater is part of their installed binary.
Validation
dotnet format --verify-no-changes