Skip to content

Fix #6257: check Map entry inclusion before deserializing key - #6258

Merged
cowtowncoder merged 3 commits into
3.xfrom
tatu-claude/3.3/6257-map-deser-ignore-props-check
Sep 30, 2026
Merged

cowtowncoder merged 3 commits into
3.xfrom
tatu-claude/3.3/6257-map-deser-ignore-props-check

Conversation

@cowtowncoder

@cowtowncoder cowtowncoder commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Summary by Gitar

  • Bug fix:
    • Fixed MapDeserializer to check inclusion filters before key deserialization in MapDeserializer.java
  • Tests:
    • Added MapIgnorePropertiesKey6257Test.java to verify ignored non-convertible map keys

This will update automatically on new commits.

@cowtowncoder cowtowncoder self-assigned this Sep 30, 2026
@github-actions

Copy link
Copy Markdown

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 82.45% 📈 +0.000%
Branches branches 76.30% 📈 +0.000%

Coverage data generated from JaCoCo test results

@github-actions

Copy link
Copy Markdown

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 82.46% 📈 +0.010%
Branches branches 76.32% 📈 +0.020%

Coverage data generated from JaCoCo test results

@gitar-bot

gitar-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Map deserialization now skips excluded raw keys before conversion, changing accepted input behavior.

Fixes MapDeserializer to check inclusion filters before deserializing map keys, preventing errors when keys should be ignored. Includes test coverage for ignored non-convertible map keys. No issues found.

Review coverage

📋 Rules No rules evaluated

🧪 Functional validation Not enabled · Set up

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@cowtowncoder cowtowncoder added this to the 3.3.0 milestone Sep 30, 2026
@cowtowncoder
cowtowncoder merged commit f44fb8e into 3.x Sep 30, 2026
5 checks passed
@cowtowncoder
cowtowncoder deleted the tatu-claude/3.3/6257-map-deser-ignore-props-check branch September 30, 2026 21:41
@github-actions

Copy link
Copy Markdown

🧪 Code Coverage Report

Metric Coverage Change
Instructions coverage 82.46% 📈 +0.010%
Branches branches 76.32% 📈 +0.020%

Coverage data generated from JaCoCo test results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant