Repository navigation
Let a workflow_dispatch choice input take its options from an enum - #696
Draft
ChrisonSimtian wants to merge 2 commits into
Draft
ChrisonSimtian wants to merge 2 commits into
ChrisonSimtian wants to merge 2 commits into
Conversation
Add OptionsFrom to GitHubActionsInputAttribute so the option list is declared once. Options are resolved in a single helper shared by validation and output. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ChrisonSimtian
added
enhancement
Enum.GetNames sorts by value, so an enum with out-of-order values gave a different dropdown order. Read the fields in declaration order instead and cover it with a non-ascending enum in the spec. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A
Choiceinput must list its options as string constants. Builds that already have an enum for the same values type the list twice, and the two copies drift.Outcome
OptionsFromproperty onGitHubActionsInputAttribute. It takes an enum type.OptionsFromrequiresType = Choice.OptionsFromis not an enum, ifOptionsis also set, ifTypeis notChoice, or ifDefaultis not an enum name.OptionsFromthe output is unchanged.Tests
GitHubActionsInputValidationSpecsfor a non-enum type, both set, a non-choice type, and a default outside or inside the enum.GitHubActionsDispatchInputSpecsthat enum options and explicit options give identical YAML.Targets
mainas a 10.4.x patch, same as the other 10.4.1 hotfix branches.