fix: packaged items should batch pattern packets like staff casting does#1027
Merged
object-Object merged 3 commits intoFallingColors:mainfrom Apr 13, 2026
Merged
Conversation
pythonmcpi
force-pushed
the
fix_artifact_packet_spam
branch
from
eb5d87b to
5a54b86
Compare
Member
object-Object
left a comment
object-Object
left a comment
There was a problem hiding this comment.
Mostly LGTM! Just a possible cleanup and a place where a comment would be useful
pythonmcpi
force-pushed
the
fix_artifact_packet_spam
branch
from
0b5b4d5 to
90763b6
Compare
object-Object
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous behavior:
Casting with a packaged item results in the server sending one packet per evaluated pattern, causing network lag
Fixed behavior:
Casting with a packaged item will batch the patterns in a set and send it all in one packet at the end, like how the StaffCastEnv already does.
Closes #1026