Implement ForceAffinity client option and set process priority from high to above normal#7160
Implement ForceAffinity client option and set process priority from high to above normal#7160lL1l1 wants to merge 6 commits into
Conversation
prevents hanging system UI when supcom freezes due to some netcode bug at the end of games when everyone is disconnecting
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description of the proposed changes
The client has a non-functional option that is supposed to toggle what we do with the process affinity. It's especially bad that the description says it does something that can troubleshoot problems:
- downlords-faf-client/src/main/resources/i18n/messages.properties#L872
This PR implements the option in the init file. Partially resolves #7060 by giving an option if the user has that error but it's still not locking the game to the first 4 cores so it may still cause the error if the game uses the e-cores while the first 4 cores are still available.
Another change is setting the process priority to above normal instead of high so that game freezes don't freeze the windows UI.
I also copied the copyable section as indicated to the other init file but I didn't particularly care about reviewing if the functionality changed because those init files haven't been updated in a long time and I couldn't find uses for them when searching the FAForever organization on Github.
Testing done on the proposed changes
Copy the changed init file to your game's local development init file and adjust ForceAffinity in the fa-path.lua file 1 directory up manually or by using client and launching the game to save the changes to the file. When running your local dev game
Checklist