Repository navigation
Improvement suggestion for CI/CD scripts #68
Description
To counter introducing regressions in future via pull requests I recommend to modify test running script nodejs.yml to include trigger that runs tests against pull requests when they are introduced.
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
Currently:
name: Node CI
on: [push]
jobs:
@@@rest of the script@@@
Suggestion:
name: Node CI
on:
push:
pull_request:
jobs:
@@@rest of the script@@@
Reacted by Jonas Birmé
Activity
birme commentedon Nov 20, 2023
I concur! :)
birme commentedon Jul 22, 2026
Thanks for the suggestion, @yaruno, and to @birme for the quick endorsement at the time!
Good news: this improvement has already been implemented. The CI workflow (
.github/workflows/nodejs.yml) now includespull_requestas a trigger alongsidepush, so all pull requests automatically run the full test matrix before merging. You can see this working on recent PRs like #81 and #82.Closing this as resolved since the requested change is in place. Thanks again for the thoughtful contribution to the project's CI health.
node-srt maintenance bot — closing as resolved; CI pull_request trigger is already in place.