Bump Node to 24.19.0 and enforce npm >= 11.10.0 toolchain - #52
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
NicolasBonet
marked this pull request as ready for review
September 2, 2026 16:32
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
melvin-bot
Bot
requested review from
blimpich
and removed request for
a team
September 2, 2026 16:32
blimpich
approved these changes
Sep 2, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Prep for rolling out npm's
min-release-agecooldown (https://github.com/Expensify/Expensify/issues/636594). That setting requires npm >= 11.10.0, so this bumps and enforces the toolchain first:.nvmrc:24.11.0->24.19.0package.json: adddevEnginesrequiringnode >= 24.19.0/npm >= 11.10.0(same block asexpensify-common). Only applies to contributors, not consumers of the published package..circleci/config.yml: bump the executor image fromcircleci/node:16tocimg/node:24.19.0to match.nvmrc. CircleCI no longer seems to run on this repo, so happy to delete the file instead if preferred.No
.npmrcormin-release-ageyet — that's a follow-up.Fixed Issues
For https://github.com/Expensify/Expensify/issues/678052
Tests
nvm use 24.19.0 && npm cisucceedsnpm run lintandnpm testpassnvm use 24.11.0 && npm ci --ignore-scriptsfails withEBADDEVENGINES