Skip to content

Bump Node to 24.19.0 and enforce npm >= 11.10.0 toolchain - #52

Merged
blimpich merged 1 commit into
mainfrom
nicolas-node-24-19-devengines
Sep 2, 2026
Merged

Bump Node to 24.19.0 and enforce npm >= 11.10.0 toolchain#52
blimpich merged 1 commit into
mainfrom
nicolas-node-24-19-devengines

Conversation

@NicolasBonet

@NicolasBonet NicolasBonet commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Details

Prep for rolling out npm's min-release-age cooldown (https://github.com/Expensify/Expensify/issues/636594). That setting requires npm >= 11.10.0, so this bumps and enforces the toolchain first:

  • .nvmrc: 24.11.0 -> 24.19.0
  • package.json: add devEngines requiring node >= 24.19.0 / npm >= 11.10.0 (same block as expensify-common). Only applies to contributors, not consumers of the published package.
  • .circleci/config.yml: bump the executor image from circleci/node:16 to cimg/node:24.19.0 to match .nvmrc. CircleCI no longer seems to run on this repo, so happy to delete the file instead if preferred.

No .npmrc or min-release-age yet — that's a follow-up.

Fixed Issues

For https://github.com/Expensify/Expensify/issues/678052

Tests

  1. nvm use 24.19.0 && npm ci succeeds
  2. npm run lint and npm test pass
  3. nvm use 24.11.0 && npm ci --ignore-scripts fails with EBADDEVENGINES

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@NicolasBonet
NicolasBonet marked this pull request as ready for review September 2, 2026 16:32
@NicolasBonet

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@NicolasBonet
NicolasBonet requested a review from a team September 2, 2026 16:32
exfy-clabot Bot added a commit to Expensify/CLA that referenced this pull request Sep 2, 2026
@melvin-bot
melvin-bot Bot requested review from blimpich and removed request for a team September 2, 2026 16:32
@blimpich
blimpich merged commit fbce525 into main Sep 2, 2026
5 of 7 checks passed
@blimpich
blimpich deleted the nicolas-node-24-19-devengines branch September 2, 2026 20:32
@os-botify

os-botify Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Published to npm in 1.0.16 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants