Skip to content

Add the add_delegate validate code reason - #940

Merged
2 commits merged into
Expensify:mainfrom
allgandalf:add-delegate-validate-code-reason
Sep 7, 2026
Merged

Add the add_delegate validate code reason#940
2 commits merged into
Expensify:mainfrom
allgandalf:add-delegate-validate-code-reason

Conversation

@allgandalf

@allgandalf allgandalf commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Adds the add_delegate reason so App can pass it when you invite a copilot. The backend half is https://github.com/Expensify/Auth/pull/24274.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/679000

Tests

  1. None, this is a constant.
  2. Added it to the installed copy in App and confirmed [HOLD Auth 24274][HOLD expensify-common 940] Send the add_delegate validate code reason App#100442 typechecks against it.

QA

  1. Nothing, no behaviour change until App uses it.
  2. None.

@allgandalf
allgandalf requested a review from a team as a code owner September 5, 2026 14:31
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@allgandalf

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

exfy-clabot Bot added a commit to Expensify/CLA that referenced this pull request Sep 5, 2026
@carlosmiceli carlosmiceli closed this pull request by merging all changes into Expensify:main in eb6fcf7 Sep 7, 2026
@melvin-bot melvin-bot Bot added the Emergency Marks a change in which we bypassed our normal process (eg, skipped travis) label Sep 7, 2026
@melvin-bot

melvin-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

@ looks like this was merged without a test passing. These checks had not passed on b88f289 when it was merged:

Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@carlosmiceli carlosmiceli removed the Emergency Marks a change in which we bypassed our normal process (eg, skipped travis) label Sep 7, 2026
@carlosmiceli

Copy link
Copy Markdown
Contributor

Mmmm, no, tests showed all passing when I merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants