[No QA] Remove sequenceNumber - #929
Merged
Merged
Conversation
s77rt
commented
Jul 13, 2026
s77rt
marked this pull request as ready for review
July 25, 2026 21:00
melvin-bot
Bot
requested review from
stitesExpensify
and removed request for
a team
July 25, 2026 21:01
Member
Author
|
@chiragsalian Please review (for some reason I can't add reviewers in this repo) |
Member
Author
|
The failing tests are probably unrelated, please re-run |
Contributor
|
@MelvinBot merge main |
stitesExpensify
approved these changes
Jul 27, 2026
Contributor
|
Ah the synk failure. We recently stopped using synk so we've to disable in repos that still use it. I've to push a PR to disable it for expensify-common. |
Contributor
|
@s77rt, we disabled synk but for the check you clear you need to push another commit, or merge with main. |
This reverts commit 2d6ab8b.
Member
Author
|
@chiragsalian This is good for merge now |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed functions that are no longer needed/used, these are based on
sequenceNumberand we are removing that from backend so these function should not be kept.insertIntoCachegetan alias togetFlatHistory(they have same outcome, even though thegetfunction sends aoffsetparam, this param is not used in Web-E)Fixed Issues
https://github.com/Expensify/Expensify/issues/589297
Tests
n/a
QA
n/a