Skip to content

upgrade: bump expensify-common to 2.0.201 - #99884

Merged
JS00001 merged 5 commits into
Expensify:mainfrom
Uzaifm127:95210-bump-expensify-common-2-0-201
Sep 1, 2026
Merged

JS00001 merged 5 commits into
Expensify:mainfrom
Uzaifm127:95210-bump-expensify-common-2-0-201

Conversation

@Uzaifm127

@Uzaifm127 Uzaifm127 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Bump expensify-common from 2.0.198 to 2.0.201 to consume the optimized ExpensiMark parser from expensify-common#937.

This makes the App use the optimized candidate scanning for autolinks, bold, and strikethrough while keeping the existing ExpensiMark matching and replacement behavior.

This PR only updates the dependency version

Fixed Issues

$ #95210
PROPOSAL:

Tests

  1. Open the App
  2. Go to any chat.
  3. Paste the text containing markdown in the composer, for example:
    • *bold*
    • _italic_
    • ~strikethrough~
    • example.com
    • https://example.com/path
    • ftp://example.com/file
    • `inline code`
    • > Quote
    • # Heading
    • [Example](https://example.com)
    • ![example.com](https://example.com/video.mp4)
  4. Verify that the markdown formatting in the composer matches the markdown formatting in production in the composer.
  5. Send each message.
  6. Verify that the rendered sent message also matches the production.
  • Verify that no errors appear in the JS console

Offline tests

Same as Test

QA Steps

Same as Test

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@Uzaifm127
Uzaifm127 requested a review from a team as a code owner August 31, 2026 05:43
@melvin-bot
melvin-bot Bot requested a review from linhvovan29546 August 31, 2026 05:43
@melvin-bot

melvin-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 31, 2026 05:43
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7223dd59d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json Outdated
@linhvovan29546

Copy link
Copy Markdown
Contributor

@Uzaifm127 I think this PR still needs QA. We need to make sure the ExpensiMark parser works correctly as it did before.

@Uzaifm127 Uzaifm127 changed the title [NO QA] upgrade: bump expensify-common to 2.0.201 upgrade: bump expensify-common to 2.0.201 Aug 31, 2026
@Uzaifm127

Copy link
Copy Markdown
Contributor Author

@linhvovan29546 Yes, thanks for that.

I thought QA would be done in the final PR for this issue. We also need to QA this PR to verify that the optimized ExpensiMark behavior is preserved.

Updating the PR title and Test steps...

@JS00001

JS00001 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@Uzaifm127

Error: Diff found when Github Actions were rebuilt. Did you forget to run `npm run gh-actions-build` after a clean install (`rm -rf node_modules && npm i`)? Do you need to merge main? Did you try running `git config --global core.autocrlf false` then `npm run gh-actions-build` again?

@Uzaifm127

Uzaifm127 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@JS00001

Fixed the GH failing check.

Will look into the other checks.

Other failing checks weren't related to this PR. Merging main solved all of them.

@JS00001

JS00001 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@linhvovan29546 back to you

@linhvovan29546

Copy link
Copy Markdown
Contributor

@Uzaifm127 Can you please add the QA steps?

@linhvovan29546

linhvovan29546 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-09-01.at.18.59.05.mov
Android: mWeb Chrome
Screen.Recording.2026-09-01.at.18.54.57.mov
iOS: HybridApp
Screen.Recording.2026-09-01.at.19.02.10.mov
iOS: mWeb Safari
Screen.Recording.2026-09-01.at.18.44.00.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-01.at.18.39.41.mov

@linhvovan29546 linhvovan29546 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melvin-bot
melvin-bot Bot requested a review from JS00001 September 1, 2026 12:04
@Uzaifm127

Uzaifm127 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

@linhvovan29546

We need to provide QA steps to check whether the existing ExpensiMark behavior is still preserved after the optimization.

I was confused about what steps we should provide because there are lots of different cases to test. Listing every case in the QA steps doesn't make sense, so I thought we could provide the essential cases that are enough to test the optimized parser.

Before adding the QA steps, I am verifying them locally one more time.

@linhvovan29546 Agree?

Thanks.

@linhvovan29546

Copy link
Copy Markdown
Contributor

I was confused about what steps we should provide because there are lots of different cases to test. Listing every case in the QA steps doesn't make sense, so I thought we could provide the essential cases that are enough to test the optimized parser.

I think just mentioning that the Markdown works the same as in production is fine.

@JS00001
JS00001 merged commit bb70da4 into Expensify:main Sep 1, 2026
40 of 42 checks passed
@JS00001

JS00001 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Lets make sure the QA steps are up to date before this goes to staging, thanks!

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Uzaifm127

Copy link
Copy Markdown
Contributor Author

Updated the QA steps.

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.66-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.68-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.68-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants