upgrade: bump expensify-common to 2.0.201 - #99884
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7223dd59d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@Uzaifm127 I think this PR still needs QA. We need to make sure the |
|
@linhvovan29546 Yes, thanks for that. I thought QA would be done in the final PR for this issue. We also need to QA this PR to verify that the optimized Updating the PR title and Test steps... |
|
…mp-expensify-common-2-0-201
|
Fixed the GH failing check.
Other failing checks weren't related to this PR. Merging main solved all of them. |
…mp-expensify-common-2-0-201
|
@linhvovan29546 back to you |
|
@Uzaifm127 Can you please add the QA steps? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-01.at.18.59.05.movAndroid: mWeb ChromeScreen.Recording.2026-09-01.at.18.54.57.moviOS: HybridAppScreen.Recording.2026-09-01.at.19.02.10.moviOS: mWeb SafariScreen.Recording.2026-09-01.at.18.44.00.movMacOS: Chrome / SafariScreen.Recording.2026-09-01.at.18.39.41.mov |
linhvovan29546
left a comment
There was a problem hiding this comment.
NAB #99884 (comment)
|
We need to provide QA steps to check whether the existing I was confused about what steps we should provide because there are lots of different cases to test. Listing every case in the QA steps doesn't make sense, so I thought we could provide the essential cases that are enough to test the optimized parser. Before adding the QA steps, I am verifying them locally one more time. @linhvovan29546 Agree? Thanks. |
I think just mentioning that the Markdown works the same as in production is fine. |
|
Lets make sure the QA steps are up to date before this goes to staging, thanks! |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Updated the QA steps. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.66-0 🚀
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.68-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.68-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Bump
expensify-commonfrom2.0.198to2.0.201to consume the optimizedExpensiMarkparser from expensify-common#937.This makes the App use the optimized candidate scanning for autolinks, bold, and strikethrough while keeping the existing
ExpensiMarkmatching and replacement behavior.This PR only updates the dependency version
Fixed Issues
$ #95210
PROPOSAL:
Tests
*bold*_italic_~strikethrough~example.comhttps://example.com/pathftp://example.com/file`inline code`> Quote# Heading[Example](https://example.com)Offline tests
Same as Test
QA Steps
Same as Test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari