add scrollview and add centering for import spreadsheet page#87984
Conversation
|
@codex review |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 063dd79f65
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <ScrollView | ||
| style={styles.h100} | ||
| contentContainerStyle={[styles.flexGrow1, styles.justifyContentCenter, styles.alignItemsCenter]} | ||
| > |
There was a problem hiding this comment.
Recompute drop overlay offset in scrollable import view
Making desktopView scrollable introduces a new state where users can scroll before dragging a file, but the drop overlay is still positioned using fileTopPosition captured once from onLayout. In web drag-and-drop flows, this means after scrolling the import screen the overlay image/text can appear at the wrong vertical offset (sometimes off-screen), because styles.fileUploadImageWrapper(fileTopPosition) no longer matches the current scroll position. This only happens in the new scrollable layout, so the offset should be updated on scroll (or the overlay should avoid absolute top pinning).
Useful? React with 👍 / 👎.
Explanation of Change
Added a ScrollView and necessary centering.
Fixed Issues
$#87406
PROPOSAL:
Tests
Prerequisite: App is being navigated in landscape mode.
Prerequisite 2: At least one workspace created with "Categories" enabled.
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
Screen.Recording.2026-04-15.at.17.11.26.mov