Skip to content

Rename Reports page to Spend#87974

Open
MelvinBot wants to merge 5 commits intomainfrom
claude-renameReportsToSpend
Open

Rename Reports page to Spend#87974
MelvinBot wants to merge 5 commits intomainfrom
claude-renameReportsToSpend

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

@MelvinBot MelvinBot commented Apr 15, 2026

Explanation of Change

Renames the left navigation tab and page header from "Reports" to "Spend" and updates the tab icon from MoneySearch to ReceiptMultiple, as described in the linked issue. Only the user-facing page label is changed — workspace settings keys, internal identifiers (Sentry labels, telemetry spans, Onyx keys), and route URLs are intentionally left unchanged per the issue scope.

Changes:

  • src/languages/en.ts: added new common.spend key with value 'Spend'
  • src/languages/es.ts: added new common.spend key with value 'Gastos'
  • All other locale files: auto-generated translations updated via generateTranslations.ts
  • src/components/Navigation/NavigationTabBar/SearchTabButton.tsx: icon changed from MoneySearch to ReceiptMultiple, label changed from common.reports to common.spend
  • src/components/Navigation/SearchSidebar.tsx: breadcrumb label changed from common.reports to common.spend
  • src/components/Search/SearchPageHeader/SearchPageHeaderNarrow.tsx: breadcrumb label changed from common.reports to common.spend
  • src/components/Search/SearchPageHeader/SearchPageHeaderWide.tsx: fallback breadcrumb label changed from common.reports to common.spend
  • src/pages/Search/SearchPageNarrow/index.tsx: breadcrumb label changed from common.reports to common.spend

Fixed Issues

$ #87969
PROPOSAL: #87969 (comment)

AI Tests

Ran by MelvinBot:

  • npx prettier --write on changed files — passed (no formatting changes needed)
  • npx eslint --max-warnings=0 on changed files — passed
  • npm run typecheck (tsc) — passed
  • npm run prettier -- --log-level error — passed
  • npx ts-node ./scripts/generateTranslations.ts --dry-run — passed (generated translations for all locale files)
  • npm test -- --silent — started but did not complete within the CI time window (full test suite is very large; these changes are string-only and icon-only with no logic modifications)

Human Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A — this change is purely cosmetic (label text and icon). No network-dependent behavior is affected.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

  1. Open the app and look at the left navigation (wide layout) or bottom tab bar (narrow layout)
  2. Verify the tab that previously said "Reports" now says "Spend"
  3. Verify the tab icon is the receipt-multiple icon instead of the previous money-search icon
  4. Tap the "Spend" tab and verify it navigates to the same search/reports page as before
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@OSBotify

This comment has been minimized.

Comment thread src/languages/en.ts Outdated
newFeature: 'New feature',
search: 'Search',
reports: 'Reports',
reports: 'Spend',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot this translation key is used in many places. Create new key: spend: 'Spend'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Reverted common.reports back to its original value ('Reports') and created a new common.spend: 'Spend' key. Updated SearchTabButton to use translate('common.spend') for the tab label. Translations added to all locale files.

…al value

common.reports is used in many places, so instead of changing its value,
create a new common.spend key and use it in SearchTabButton for the tab label.

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@OSBotify
Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 4c21d14c..4ac86802 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -110,7 +110,7 @@ const translations: TranslationDeepObject<typeof en> = {
         newFeature: 'Nouvelle fonctionnalité',
         search: 'Rechercher',
         reports: 'Notes de frais',
-        spend: 'Dépenses',
+        spend: 'Dépense',
         find: 'Rechercher',
         searchWithThreeDots: 'Rechercher...',
         next: 'Suivant',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 374ad75e..e95d8df0 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -110,7 +110,7 @@ const translations: TranslationDeepObject<typeof en> = {
         newFeature: 'Nuova funzionalità',
         search: 'Cerca',
         reports: 'Report',
-        spend: 'Spese',
+        spend: 'Spesa',
         find: 'Trova',
         searchWithThreeDots: 'Cerca...',
         next: 'Avanti',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 45c78b4e..bd290a73 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -110,7 +110,7 @@ const translations: TranslationDeepObject<typeof en> = {
         newFeature: 'Novo recurso',
         search: 'Buscar',
         reports: 'Relatórios',
-        spend: 'Gastos',
+        spend: 'Gastar',
         find: 'Localizar',
         searchWithThreeDots: 'Buscar...',
         next: 'Próximo',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...Search/SearchPageHeader/SearchPageHeaderNarrow.tsx 80.00% <100.00%> (ø)
...ts/Navigation/NavigationTabBar/SearchTabButton.tsx 47.05% <75.00%> (ø)
src/components/Navigation/SearchSidebar.tsx 0.00% <0.00%> (ø)
...s/Search/SearchPageHeader/SearchPageHeaderWide.tsx 0.00% <0.00%> (ø)
... and 16 files with indirect coverage changes

@situchan
Copy link
Copy Markdown
Contributor

@MelvinBot there are more places to update copy:

breadcrumbLabel={translate('common.reports')}

breadcrumbLabel={translate('common.reports')}

const title = activeItemIndex >= 0 && selectedItem ? translate(selectedItem.translationPath) : translate('common.reports');

breadcrumbLabel={translate('common.reports')}

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot
Copy link
Copy Markdown
Contributor Author

Updated all four locations to use common.spend instead of common.reports:

  • src/components/Navigation/SearchSidebar.tsx (breadcrumb label)
  • src/components/Search/SearchPageHeader/SearchPageHeaderNarrow.tsx (breadcrumb label)
  • src/components/Search/SearchPageHeader/SearchPageHeaderWide.tsx (fallback breadcrumb label)
  • src/pages/Search/SearchPageNarrow/index.tsx (breadcrumb label)

The only remaining translate('common.reports') usage is in WorkspaceReportsPage.tsx (workspace settings), which is intentionally unchanged.

@situchan
Copy link
Copy Markdown
Contributor

@MelvinBot complete author checklist and mark as ready for review

@MelvinBot MelvinBot marked this pull request as ready for review April 15, 2026 14:46
@MelvinBot MelvinBot requested a review from a team as a code owner April 15, 2026 14:46
@melvin-bot melvin-bot bot requested review from a team, JmillsExpensify and situchan and removed request for a team April 15, 2026 14:47
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 15, 2026

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@MelvinBot
Copy link
Copy Markdown
Contributor Author

Completed the author checklist and marked the PR as ready for review. Non-applicable items (no new files, no new CSS, no new assets, no message editing, no generic component changes, no storybook, no deeplinks, no UI layout changes, no new pages, no unit tests needed for string/icon-only change) were marked as N/A.

@melvin-bot melvin-bot bot requested review from lakchote and removed request for a team April 15, 2026 14:47
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 15, 2026

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@situchan
Copy link
Copy Markdown
Contributor

@MelvinBot check off all items in author checklist even if unrelated. Not N/A

@situchan
Copy link
Copy Markdown
Contributor

situchan commented Apr 15, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android.mov
Android: mWeb Chrome
mchrome.mov
iOS: HybridApp
ios.mov
iOS: mWeb Safari
msafari.mov
MacOS: Chrome / Safari
web.mov

@situchan
Copy link
Copy Markdown
Contributor

@MelvinBot replace this image:

home-testdrive-image

/assets/images/home-testdrive-image.png

Use this file: NewTestDriveImage.zip

@JmillsExpensify
Copy link
Copy Markdown
Contributor

Going to kick off an adhoc!

Also let's not merge this PR until we get the green light from @stephanieelliott

@github-actions
Copy link
Copy Markdown
Contributor

🚧 @JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot MelvinBot requested review from a team as code owners April 15, 2026 15:14
@MelvinBot
Copy link
Copy Markdown
Contributor Author

Replaced assets/images/home-testdrive-image.png with the new image.

@melvin-bot melvin-bot bot requested review from arosiclair and removed request for a team April 15, 2026 15:14
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 15, 2026

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@situchan
Copy link
Copy Markdown
Contributor

@shawnborton here's new look:

web ios

Copy link
Copy Markdown
Contributor

@situchan situchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Hold merge as per #87974 (comment)

@shawnborton
Copy link
Copy Markdown
Contributor

Looks good to me 👍

Copy link
Copy Markdown
Contributor

@lakchote lakchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Waiting for @stephanieelliott's approval

@JmillsExpensify
Copy link
Copy Markdown
Contributor

Looks super good. We will send the signal when we're ready to merge. Waiting on internal announcements and documentation.

@dannymcclain
Copy link
Copy Markdown
Contributor

Love it!

@situchan
Copy link
Copy Markdown
Contributor

@MelvinBot pull main and fix conflict

The conflict arose because main refactored SearchPageHeaderNarrow to
handle breadcrumbLabel internally, while our branch changed the
breadcrumbLabel prop at the call site. Resolved by taking main's
version (isMobileSelectionModeEnabled prop) since the common.spend
label change is already applied inside the component on main.

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot
Copy link
Copy Markdown
Contributor Author

Merged main and resolved the conflict in src/pages/Search/SearchPageNarrow/index.tsx.

The conflict was because main refactored SearchPageHeaderNarrow to handle breadcrumbLabel internally (and already applied the common.spend change there), while our branch was still passing it as a prop. Resolved by taking main's version (isMobileSelectionModeEnabled={false} prop), since the label rename is already handled inside the component.

@JmillsExpensify
Copy link
Copy Markdown
Contributor

This PR is cleared to be merged to staging. We'll make the help/AZ updates today, and those goes straight production.

@stephanieelliott
Copy link
Copy Markdown
Contributor

I'll have the documentation updates all done today - I'll link the PR here so we can time that to merge the same time this PR hits prod.

@stephanieelliott stephanieelliott requested review from a team and arosiclair and removed request for a team and arosiclair April 15, 2026 22:40
@stephanieelliott
Copy link
Copy Markdown
Contributor

Help changes are ready in this PR: #88010

@JmillsExpensify
Copy link
Copy Markdown
Contributor

@lakchote Go ahead and merge this one if you're comfortable with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants