Repository navigation
Conversation
7 of 42 tasks
Contributor
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Pins
react-native-onyxto the HEAD of Expensify/react-native-onyx#854 so E/App CI runs against it. Once #854 is merged and published, this PR switches to the npm version and becomes the bump PR.Follow-up to Expensify/react-native-onyx#853. When IndexedDB stays broken after Onyx reopens the connection 3 times, Onyx now moves the session to in-memory storage (
MemoryOnlyProvider) instead of sending every read and write to a dead database. It also moves to memory at init when the firstgetAllfails with a fatal error. The app keeps working for the session. Nothing persists across reloads, but persistence was already broken for these users.Fixed Issues
$ #102272
PROPOSAL: #102272 (comment)
Tests
heal budget exhaustedalert followed byFalling back to only using cache.Offline tests
QA Steps
The failure only reproduces on a browser whose IndexedDB is broken, so QA is a regression pass:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari