[NoQA] Onyx GET asynchronous - Phase 0a

[LukasMod]

Explanation of Change

1. New lint rule rulesdir/no-unsafe-onyx-read, on repo-wide. It allows Onyx.get only under src/components, src/pages, src/hooks and tests, and refuses it during render, at module scope, inside code an effect runs, on a Search snapshot key, and on any key lint cannot resolve. When ESLint loads it, the rule reads SEARCH_SNAPSHOT_ONYX_KEYS out of src/CONST/runtimeConfigured.ts and throws if that list ever moves, so the snapshot check fails closed instead of switching itself off.
2. The bypass guard in scripts/onyxConnectBypass.ts now owns two bans instead of one. An inline eslint-disable of the new rule fails the lint run the same way one of Onyx.connect() does, and scripts/checkOnyxConnectBypass.ts drives both checks from the lint pipeline. It carries one grandfathered allowance for src/setup/addUtilsToWindow.ts.
3. New review rule ONYX-1 in the coding standards skill, for what lint cannot see: a read that reaches render through another file, an effect defined elsewhere, a read ordered after a write in the same tick, a derived key read after its sources were written, and a value parked in state, a ref, or a module variable.
4. ONYX-DATA-MANAGEMENT.md lists Onyx.get() as a third read path next to useOnyx and Onyx.connectWithoutView, with five rules and a pointer to the lint rule and ONYX-1.
5. react-native-onyx moves from 3.0.111 to b3c781503af (3.0.115), where Onyx.get(key) is public and typed Promise<OnyxValue<TKey>>, with no readonly wrapper on the result. No app code reads with it: no new Onyx.get call site appears anywhere in src.
6. The dev console loses its hand-made Onyx.get. addUtilsToWindow.ts used a connectWithoutView shim and react-native-onyx.d.ts declared it on Window, both only because the library had no get. Deleting the shim and that one declaration line is the whole source change, 21 lines removed. window.Onyx.get, Onyx.log, window.report and friends now go through the library method, and the call sites in that file are untouched.

The grandfathered allowance for src/setup/addUtilsToWindow.ts in the bypass guard is unused today, since the console helper's window.Onyx.get calls are not the bare Onyx.get the rule watches. It would tolerate one future bypass in that file, which buys the follow-up work a file that can disable the rule without a new guard change.

Rule logic and bypass detection are automated: tests/unit/NoUnsafeOnyxReadRuleTest.ts (154 cases) and tests/unit/OnyxConnectBypassTest.ts (25 cases) both pass. So does npm run typecheck, the 15 Onyx suites in tests/unit (336 tests), all of tests/actions (2474 tests), and a full npm run lint. The manual steps cover what those cannot reach: the rule against the real source tree, its wiring through the flat config and the lint pipeline, and the dev console helpers on the real Onyx.get.

react native onyx PR: Expensify/react-native-onyx#850

Fixed Issues

$ #101910
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

Test 1: Smoke test after the Onyx bump

1. Load the app and sign in.
2. Confirm the LHN, the chat list and the Inbox load without errors in the console.
3. Open a chat, send a message, and confirm it appears right away.
4. Open an expense, edit its amount, and confirm the new amount shows.
5. Go offline, send another message, then go back online.
6. Confirm the queued message is sent and nothing is duplicated.

Test 2: Dev console helpers

Prerequisite: a non-production (dev) build, with the browser console open.

1. Open a chat or expense report so its IDs are in the route.
2. Run await Onyx.get('session') and confirm it returns the session object.
3. Run Onyx.log('session') and confirm the session is logged.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-09-24.at.11.08.10.mov

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[LukasMod]

I’ll keep it as a draft until the Onyx change is merged and we can properly bump the Onyx version here