[WIP] [LegendList 2/7] fix: use list-aware message edit scrolling - #100883
Open
chrispader wants to merge 3 commits into
Open
[WIP] [LegendList 2/7] fix: use list-aware message edit scrolling#100883chrispader wants to merge 3 commits into
chrispader wants to merge 3 commits into
Conversation
This was referenced Sep 10, 2026
[HOLD on #100740] [LegendList 6/7] feat: migrate remaining FlashList consumers to LegendList
#100734
Draft
chrispader
marked this pull request as ready for review
September 11, 2026 10:16
melvin-bot
Bot
requested review from
dmkt9 and
dylanexpensify
and removed request for
a team
September 11, 2026 10:16
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
chrispader
force-pushed
the
@chrispader/fix/report-action-edit-scroll
branch
from
September 11, 2026 10:44
a796f48 to
e9e6f3b
Compare
dylanexpensify
left a comment
Contributor
There was a problem hiding this comment.
Performance related vs pure product update. Input not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In expense views, message-edit scrolling currently assumes the main report action list is inverted.
MoneyRequestReportActionsListorders items chronologically, so editing its newest message can ask the wrong list position to stay visible. This WIP extraction makes message-edit scrolling list-aware while preserving existing report behavior.@roryabraham @dmkt9
Explanation of Change
The existing report action position context now carries both the action index and whether the action is newest, so each list declares its own ordering semantics.
MoneyRequestReportActionsListalso provides a separate list-level callback that scrolls to its newest position, while the inverted main report list keeps the existing report scroll manager fallback.This is layer 2 of the seven-part LegendList series. Review order is #100732 → this PR → #100884 → #100733 → #100740 → #100734 → #100736. The branches are maintained with GH Stacks in the Margelo fork; because GitHub does not support linking cross-fork heads into an upstream Stack, each upstream PR targets
Expensify/App:mainand records the dependency order here.Fixed Issues
$ #98994
PROPOSAL:
No approved proposal is linked.
Tests
Offline tests
QA Steps
Same as Tests and Offline tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screenshots and videos are not included while this PR is WIP.