[No QA] Docs updates for E/A#100354 scope who can pay reports besides payer - #100492
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#100354 scope who can pay reports besides payer#100492MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Chuck Dries <chuckdries@users.noreply.github.com>
41 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://17adb4e5.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to #100354, which reverted #95925 ("Allow any workspace admin to pay reports") while #100353 is investigated.
The revert restores the pre-existing rule that who can pay a report depends on the workspace's reimbursement setup. But
Workspace-Workflows.mdended with a flat, unscoped sentence — "Other admins can still open a report and pay it." — under the What happens after you set an authorized payer heading. That heading is not scoped to the no-bank-account case, so an admin on a workspace with a connected bank account could read it and expect a Pay button they will never see. #100353 is exactly that confusion turning into an error.This PR replaces that sentence with the two actual cases:
Both behaviors are read off the post-revert code:
src/libs/ReportPrimaryActionUtils.ts:235-240gates the non-payer admin path onreimbursementChoice === REIMBURSEMENT_MANUAL, andsrc/libs/ReportUtils.ts:3008-3017returnsisReimburser || (isAdmin && hasAccessToBankAccount)for auto reimbursement and reimburser-only for manual.A cross-link to Share a business bank account was added so admins who need access know where to go, and
who can pay a reportwas added to the article keywords.UI labels used in the copy were verified against the live app rather than taken from memory: the Workflows page shows a Payments section and a Payer row (whose picker screen is headed Authorized payer), and the Pay button on an approved report offers Pay with business account and Mark as paid.
Note for the reviewer: two draft docs PRs already open — #100364 and #100349 — document the pre-revert behavior ("any Workspace Admin can pay"). Now that #95925 is reverted, neither should merge as written. They should be closed or held until the feature relands.
Fixed Issues
$ #100354
PROPOSAL:
Tests
// TODO: The human co-author must confirm the documented behavior before marking this PR as "ready for review". Suggested check:
Offline tests
N/A — documentation only, no app code changed.
QA Steps
No QA — this PR only changes help site markdown under
docs/articles. There is no app behavior to test on staging.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@chuckdries, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.