Skip to content

[Phase 4] - Remove module-level reportAttributesDerivedValue in isEmptyReport() - #100447

Draft
hoangzinh wants to merge 1 commit into
Expensify:mainfrom
hoangzinh:66427/phase4-isEmptyReport-remove-derived-value
Draft

[Phase 4] - Remove module-level reportAttributesDerivedValue in isEmptyReport()#100447
hoangzinh wants to merge 1 commit into
Expensify:mainfrom
hoangzinh:66427/phase4-isEmptyReport-remove-derived-value

Conversation

@hoangzinh

@hoangzinh hoangzinh commented Sep 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Remove module-level reportAttributesDerivedValue read inside isEmptyReport() by accepting an optional derivedIsEmptyReport parameter, mirroring Phase 2's derivedReportName pattern.

  • Add reportIsEmptySelector to ReportAttributes selectors
  • Add useDerivedIsEmptyReportByReportID hook
  • Thread derivedIsEmptyReport through isUnread, reasonForReportToBeInOptionList, and ShouldReportBeInOptionListParams
  • Update call sites in SidebarUtils, OptionsListUtils, DebugUtils, MarkAllMessageAsRead, and components/hooks
  • Add tests for new hook

Fixed Issues

$ #66427
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

1. LHN displays reports correctly

  1. Check chat list in LHN
  2. Verify empty chats do NOT appear
  3. Verify non-empty unread chats show bold text
  4. Verify pinned empty chats still appear

2. Inbox Unread tab and Mark all as read

  1. Go to Inbox, switch to Unread tab
  2. Verify only reports with unread messages appear
  3. Verify empty reports do NOT appear in Unread tab
  4. Long-press on Unread tab, select "Mark all as read"
  5. Verify all unread indicators are cleared and Unread tab count goes to 0

3. Report View — Expense report marks as read

  1. Have another user send a message in an expense report
  2. Open that unread expense report
  3. Verify unread indicator disappears after viewing

4. Report View — Chat navigates to unread position

  1. Have another user send multiple messages in a chat
  2. Open that unread chat
  3. Verify chat scrolls to correct unread position

5. Search displays correct unread state

  1. Go to Search
  2. Search for a chat that has unread messages
  3. Verify search results show correct bold/unread state
  4. Search for an empty chat
  5. Verify empty chat does not show as unread/bold
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2026-09-06.195109.mp4

@codecov

codecov Bot commented Sep 6, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...equestReportView/MoneyRequestReportActionsList.tsx 60.56% <100.00%> (+0.12%) ⬆️
src/hooks/useMarkAsRead.ts 95.94% <100.00%> (+0.05%) ⬆️
src/hooks/useReportActionsListModel.ts 100.00% <100.00%> (ø)
src/hooks/useReportAttributes.ts 81.25% <100.00%> (+4.32%) ⬆️
src/libs/DebugUtils.ts 69.00% <ø> (ø)
src/libs/OptionsListUtils/index.ts 91.29% <100.00%> (ø)
src/libs/ReportUtils.ts 87.38% <100.00%> (+0.11%) ⬆️
src/libs/SidebarUtils.ts 90.53% <100.00%> (+0.09%) ⬆️
src/libs/actions/Report/MarkAllMessageAsRead.tsx 90.32% <100.00%> (ø)
...report/ContextMenu/BaseReportActionContextMenu.tsx 87.65% <100.00%> (+0.07%) ⬆️
... and 5 more
... and 8 files with indirect coverage changes

@hoangzinh
hoangzinh force-pushed the 66427/phase4-isEmptyReport-remove-derived-value branch 2 times, most recently from 824f452 to e41aaa2 Compare September 6, 2026 13:17
@hoangzinh
refactor(ReportUtils): pass derivedIsEmptyReport from outside
7103dee 
Remove module-level reportAttributesDerivedValue read inside
isEmptyReport() by accepting an optional derivedIsEmptyReport
parameter, mirroring Phase 2's derivedReportName pattern.

- Add reportIsEmptySelector to ReportAttributes selectors
- Add useDerivedIsEmptyReportByReportID/sByReportIDs hooks
- Thread derivedIsEmptyReport through isUnread,
  reasonForReportToBeInOptionList, and ShouldReportBeInOptionListParams
- Update call sites in SidebarUtils, OptionsListUtils, DebugUtils,
  MarkAllMessageAsRead, and 4 Group C components/hooks
- Leave UnreadIndicatorUpdater unchanged (falls through to
  generateIsEmptyReport)
- Add tests for isEmptyReport cache hit/miss and new hooks

Part of Expensify#66427 (Phase 4)
@hoangzinh
hoangzinh force-pushed the 66427/phase4-isEmptyReport-remove-derived-value branch from e41aaa2 to 7103dee Compare September 6, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hoangzinh hoangzinh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hoangzinh