Skip to content

Run all Jest tests through the OXC transformer - #100438

Draft
roryabraham wants to merge 2 commits into
mainfrom
rory/oxc-jest-all-tests
Draft

Run all Jest tests through the OXC transformer#100438
roryabraham wants to merge 2 commits into
mainfrom
rory/oxc-jest-all-tests

Conversation

@roryabraham

Copy link
Copy Markdown
Contributor

Explanation of Change

Regular Jest still used babel-jest for every JS/TS file, while Reassure already used the OXC transformer. The split existed because jest.mock has to be hoisted above generated require() calls.

This PR routes all Jest runs through config/babel/oxcJestTransformer.js:

  1. OXC compiles TS/JSX (React Compiler on app sources only; skipped for tests/, jest/, and __mocks__/).
  2. A small Babel pass emits loose CommonJS, lowers import(), and runs babel-plugin-jest-hoist.
  3. babel-jest remains the fallback for Flow in node_modules.

strictMode: false is required so existing tests that assign to getter-only native mock properties (e.g. AppState.currentState) keep working. The CI Jest cache key now also hashes jest.config.js and the transformer files.

Benchmark (local, --maxWorkers=6)

Suite babel-jest (before) OXC (after) Delta
tests/unit/hooks cold 45.9s Jest / 56.4s wall 26.7s Jest / 32.1s wall −42% / −43%
tests/unit/hooks warm 30.3s Jest / 45.7s wall 17.2s Jest / 22.2s wall −43% / −51%
3 UI tests cold 15.4s Jest / 29.4s wall 8.9s Jest / 16.1s wall −42% / −45%
3 UI tests warm 2.8s Jest / 14.7s wall 2.3s Jest / 8.8s wall −18% / −40%

Correctness checks on the OXC path: tests/unit/hooks (156 suites / 1606 tests), tests/actions (83 / 2293), tests/navigation (48 / 564), plus bun test ./tests/tooling/oxcTransformer.test.ts.

Fixed Issues

$
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

babel-jest was still transforming the regular suite so jest.mock stayed
hoisted. Route every JS/TS file through OXC, then a small Babel pass for
loose CJS, import() lowering, and mock hoisting. Keep babel-jest only as
the node_modules/Flow fallback.
@roryabraham roryabraham self-assigned this Sep 5, 2026
@roryabraham
roryabraham requested a review from a team September 5, 2026 01:16
CI failed with TDZ on circular imports and jest.mock factories that
closed over const. Babel used to rewrite those to var; restore that
with plugin-transform-block-scoping so existing tests keep working.
@roryabraham

Copy link
Copy Markdown
Contributor Author

HOLD: esbuild CJS still TDZs on the PersistedRequestsSequentialQueue cycle (initializationCallback). That is production module graph, not a test rewrite.

#99910 (import/no-cycle part 3) cuts Log → Network (postMainQueueStore.enqueue), which is the edge that pulls SequentialQueue into Log's import graph. Once that lands, we should re-check whether the cycle is gone before merging this.

Test-side esbuild CJS mismatches (mock-factory TDZ, jest.spyOn on named exports, RN mock getter spread) are being migrated in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant