Skip to content

[HOLD][No QA] Docs updates for E/A#100354 clarify who can pay after setting authorized payer - #100416

Draft
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-authorized-payer-bank-account
Draft

[HOLD][No QA] Docs updates for E/A#100354 clarify who can pay after setting authorized payer#100416
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-authorized-payer-bank-account

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for #100354, which reverted "Allow any workspace admin to pay reports" (#95925).

docs/articles/new-expensify/workspaces/Workspace-Workflows.md told admins:

Other admins can still open a report and pay it.

That sentence was written in July 2026 for workspaces reimbursing outside Expensify, but it sits under its own ## What happens after you set an authorized payer heading, so it reads as a blanket statement. After the revert, it is wrong for workspaces with a business bank account connected — there, only the authorized payer sees Pay. That is the exact confusion behind #100353, where a second admin tried to pay and hit an error.

What changed

  1. Split the "other admins" sentence into the two cases the code actually distinguishes:
    • No business bank account connected → other admins can still open a report and record it with Mark as paid.
    • Business bank account connected → only the authorized payer can pay; other admins don't see Pay.
  2. Added a one-line pointer that changing the Payer is how you let a different admin pay from the connected bank account.
  3. Corrected two UI labels in the same article against the live UI (verified in the app, not from memory):
    • Connect Bank AccountAdd bank account
    • Mark as PaidMark as paid (three occurrences, including one heading)

Where the behavior comes from

Post-revert, a non-payer admin only gets Pay when reimbursementChoice is REIMBURSEMENT_MANUAL — see src/libs/ReportPreviewActionUtils.ts:142-146 and src/libs/PolicyUtils.ts:703-727. With a bank account connected (REIMBURSEMENT_YES) and a payer set, isPolicyPayer returns true only for the designated payer.

Note for the reviewer: item 3 is a drive-by label fix in the same article. Say the word and I'll drop it into a separate PR.

Docs guidelines applied: no new # headings, all ## headings stay task-based, UI labels bolded in sentence case, no new cross-links.

Fixed Issues

$
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@chuckdries, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Chuck Dries <chuckdries@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 4, 2026 17:13
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 4, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#100354 clarify who can pay after setting authorized payer [No QA] Docs updates for E/A#100354 clarify who can pay after setting authorized payer Sep 4, 2026
@OSBotify

OSBotify commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://ae854f11.helpdot.pages.dev ⚡️

Updated articles:

@chuckdries chuckdries changed the title [No QA] Docs updates for E/A#100354 clarify who can pay after setting authorized payer [HOLD][No QA] Docs updates for E/A#100354 clarify who can pay after setting authorized payer Sep 4, 2026
@chuckdries

Copy link
Copy Markdown
Contributor

I'd rather fix the docs all at once when we get the any admin payer changes out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants