[HOLD][No QA] Docs updates for E/A#100354 clarify who can pay after setting authorized payer - #100416
Draft
MelvinBot wants to merge 1 commit into
Draft
[HOLD][No QA] Docs updates for E/A#100354 clarify who can pay after setting authorized payer#100416MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Chuck Dries <chuckdries@users.noreply.github.com>
41 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://ae854f11.helpdot.pages.dev ⚡️ Updated articles: |
Contributor
|
I'd rather fix the docs all at once when we get the any admin payer changes out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for #100354, which reverted "Allow any workspace admin to pay reports" (#95925).
docs/articles/new-expensify/workspaces/Workspace-Workflows.mdtold admins:That sentence was written in July 2026 for workspaces reimbursing outside Expensify, but it sits under its own
## What happens after you set an authorized payerheading, so it reads as a blanket statement. After the revert, it is wrong for workspaces with a business bank account connected — there, only the authorized payer sees Pay. That is the exact confusion behind #100353, where a second admin tried to pay and hit an error.What changed
Where the behavior comes from
Post-revert, a non-payer admin only gets Pay when
reimbursementChoiceisREIMBURSEMENT_MANUAL— seesrc/libs/ReportPreviewActionUtils.ts:142-146andsrc/libs/PolicyUtils.ts:703-727. With a bank account connected (REIMBURSEMENT_YES) and a payer set,isPolicyPayerreturns true only for the designated payer.Note for the reviewer: item 3 is a drive-by label fix in the same article. Say the word and I'll drop it into a separate PR.
Docs guidelines applied: no new
#headings, all##headings stay task-based, UI labels bolded in sentence case, no new cross-links.Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@chuckdries, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.