Reports - Exporting twice manually fails to show modal stating reports were already exporte

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

---

Version Number: 9.4.74-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/72925099/folder/13176908/96083084/1738374007
Email or phone of affected tester (no customers): biruknew45+ghkhj3@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Web, android
App Component: Other

Action Performed:

Preconditions:
Workspace connected to QBO
2 reports each with at least 1 expense created and submitted

1. Go to staging.new.expensify.com
2. Go to Spend > Reports page and select the two submitted reports
3. Approve the reports
4. Click Export > Mark as exported
5. Select the two reports again and click Mark as exported

Expected Result:

Modal stating the reports have already been exported to QuickBooks Online should appear

Actual Result:

Modal stating the reports have already been exported to QuickBooks Online does not appear

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7254689_1788919678992.bandicam_2026-09-09_05-01-01-966.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7254689

Issue Owner

Current Issue Owner: @Valforte

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/cee8f86c0776ad8cbf6b07d353091b6822193f481a090e164bfa9469e3299810

[MelvinBot]

Proposal

This is working as intended. The "already exported" warning was deliberately removed for Mark as exported by Expensify/App#99982 (merged 2026-09-07), which is in the tested build 9.4.74-0. The BrowserStack regression test case predates that change and is now stale.

What is the root cause of that problem?

The exportAgainModal ("Careful! The following reports have already been exported…") is gated to fire only for a real integration export, never for "Mark as exported". In the bulk Search path the gate is src/hooks/useSearchBulkActions.ts:1990:

if (!areAnyReportsExported || !isRealIntegrationExport) {
    runExport();
    return;
}

isRealIntegrationExport is hard-coded false for the "Mark as exported" option (useSearchBulkActions.ts:2082) and true for the real export (:2064).

The stated reason, in the code comment directly above the gate, is that MarkAsExported only logs a per-report marker and never pushes data to QuickBooks Online — so warning that reports "will be exported again" to QBO is factually wrong and blocks users from re-marking.

The same intentional skip exists on every entry point, not just Search — so single-report "Mark as exported" does not show the modal either:

All four call sites and the supporting evidence

Path	Skip
Search bulk selection	useSearchBulkActions.ts:1990
Report header Export dropdown	ExportWithDropdownMenu.tsx:140
Report details ▸ Export page	DynamicReportDetailsExportPage.tsx:161
Secondary-actions Export submenu	useExportAgainModal.ts:37-43

Version confirmation: both commits of #99982 (1ad0a209, 4604f5a2) are contained in 9.4.74-0-staging — gh api repos/Expensify/App/compare/1ad0a209...9.4.74-0-staging returns {"status":"ahead","behind":0}. That matches the report being reproducible on both staging and production.

Regression tests lock in the current behavior, so any change here would need these updated too:

• tests/unit/hooks/useExportAgainModalTest.ts:68 — expect(mockShowConfirmModal).not.toHaveBeenCalled()
• tests/unit/hooks/useSearchBulkActionsExportTest.ts

Detection is not the problem. The bulk path already computes areAnyReportsExported and exportedReportNames correctly at useSearchBulkActions.ts:1958-1981, and markAsManuallyExported sets isExportedToIntegration: true optimistically on the first click. The data is there — it is deliberately discarded.

Why the real export still warns: picking "Export to QuickBooks Online" on an already-exported report passes isRealIntegrationExport = true and does show the Careful! modal. That is the behavior the test case was originally written against.

What changes do you think we should make in order to solve the problem?

No App code change. Close this issue as expected behavior and update the BrowserStack regression test case (Reports - Exporting twice manually) so the expected result is "reports are re-marked with no confirmation modal". Keep a separate case asserting that Export to QuickBooks Online on an already-exported report still shows the Careful! modal.

What alternative solutions did you explore? (Optional)

If the product decision is to reverse #99982 and warn on re-marking, the change is small but needs new copy: dropping || !isRealIntegrationExport alone would reuse workspace.exportAgainModal.description, which says the reports "will be exported to QuickBooks Online again" — the exact wording #99982 called wrong. A separate "already marked as exported" string is required, applied to all four call sites above plus the two test files. That is a product call for whoever owns #99982, not a bug fix.

Related issues

Nothing overlapping found. Expensify/App#99028 (Spend bulk-submit modal missing) touches the same bulk-actions surface but a different action and a different root cause.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/100708) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

---

view run · view recording

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @nyomanjyotisa (External)

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[nyomanjyotisa]

@MelvinBot’s proposal looks good to me. #99982 intentionally skips the warning for Mark as exported while preserving it for real QBO exports. The BrowserStack case should be updated, then this issue can be closed.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Valforte, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MelvinBot]

Agreed — no App code change, and no PR to open. Re-confirmed on current main (d6a6cab): the gate is still src/hooks/useSearchBulkActions.ts:1990, with isRealIntegrationExport hard-coded false for Mark as exported and true for the real QBO export.

BrowserStack update needed on Reports - Exporting twice manually:

1. Change the expected result for the second Mark as exported to: reports are re-marked with no confirmation modal.
2. Add or keep a separate case asserting that Export to QuickBooks Online on an already-exported report does still show the "Careful!" modal — that path is unchanged by Expensify/App#99982.

Valforte — once the test case is updated, this can be closed as working as intended. The External label can also come off, since there's no contributor work here.

---

view run · view recording