Skip to content

fix(get-changed-files): exclude original location of renamed files when ignore_deleted is set #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danadajian merged 2 commits into from
Oct 22, 2026
Merged

fix(get-changed-files): exclude original location of renamed files when ignore_deleted is set #816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03303fe
fix(get-changed-files): exclude original location of renamed files wh…
danadajian Oct 22, 2026
d5ed4d0
chore: committing generated dist
danadajian Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/helpers/add-pr-approval-label.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import {
} from "../main-fh8gy58w.js";
import {
getCoreMemberLogins
} from "../main-33hyq3fg.js";
import"../main-8fvwf10s.js";
} from "../main-zdktbbwp.js";
import"../main-h4qz490e.js";
import {
HelperInputs
} from "../main-d5wrnkmf.js";
Expand Down
6 changes: 3 additions & 3 deletions dist/helpers/approvals-satisfied.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import {
ApprovalsSatisfied2,
approvalsSatisfied2
} from "../main-xtctj82v.js";
} from "../main-kvpz5nvm.js";
import"../main-hwzwrqja.js";
import"../main-33hyq3fg.js";
import"../main-8fvwf10s.js";
import"../main-zdktbbwp.js";
import"../main-h4qz490e.js";
import"../main-fh8gy58w.js";
import"../main-nnwtk8w8.js";
import"../main-6sabwhac.js";
Expand Down
4 changes: 2 additions & 2 deletions dist/helpers/are-reviewers-required.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import"../main-6sabwhac.js";
import"../main-fh8gy58w.js";
import {
getRequiredCodeOwnersEntries
} from "../main-33hyq3fg.js";
import"../main-8fvwf10s.js";
} from "../main-zdktbbwp.js";
import"../main-h4qz490e.js";
import {
HelperInputs
} from "../main-d5wrnkmf.js";
Expand Down
4 changes: 2 additions & 2 deletions dist/helpers/assign-pr-reviewers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ import {
} from "../main-fh8gy58w.js";
import {
getCoreMemberLogins
} from "../main-33hyq3fg.js";
} from "../main-zdktbbwp.js";
import {
notifyUser
} from "../main-c2rt2anc.js";
import"../main-hbnqs8ps.js";
import {
CORE_APPROVED_PR_LABEL
} from "../main-jq9kgsp8.js";
import"../main-8fvwf10s.js";
import"../main-h4qz490e.js";
import {
require_lodash
} from "../main-t2wes6yn.js";
Expand Down
2 changes: 1 addition & 1 deletion dist/helpers/generate-path-matrix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
} from "../main-hatr91y7.js";
import {
getChangedFilepaths
} from "../main-8fvwf10s.js";
} from "../main-h4qz490e.js";
import {
require_lodash
} from "../main-t2wes6yn.js";
Expand Down
2 changes: 1 addition & 1 deletion dist/helpers/get-changed-files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import"../main-00tcd9f5.js";
import {
getChangedFilepaths,
getChangedFilepathsFromShas
} from "../main-8fvwf10s.js";
} from "../main-h4qz490e.js";
import {
HelperInputs
} from "../main-d5wrnkmf.js";
Expand Down
4 changes: 2 additions & 2 deletions dist/helpers/is-user-core-member.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import {
import"../main-fh8gy58w.js";
import {
getCoreMemberLogins
} from "../main-33hyq3fg.js";
import"../main-8fvwf10s.js";
} from "../main-zdktbbwp.js";
import"../main-h4qz490e.js";
import {
HelperInputs
} from "../main-d5wrnkmf.js";
Expand Down
8 changes: 4 additions & 4 deletions dist/helpers/manage-merge-queue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@ import {
manageMergeQueue2,
removePrFromQueue2,
enableAutoMerge2
} from "../main-dkmveggg.js";
} from "../main-dm1emycq.js";
import"../main-d50gcstv.js";
import"../main-b3a18pad.js";
import"../main-en73eexx.js";
import"../main-j2vhxcaz.js";
import"../main-xtctj82v.js";
import"../main-kvpz5nvm.js";
import"../main-hwzwrqja.js";
import"../main-c2rt2anc.js";
import"../main-hbnqs8ps.js";
import"../main-jq9kgsp8.js";
import"../main-33hyq3fg.js";
import"../main-8fvwf10s.js";
import"../main-zdktbbwp.js";
import"../main-h4qz490e.js";
import"../main-fh8gy58w.js";
import"../main-nnwtk8w8.js";
import"../main-6sabwhac.js";
Expand Down
8 changes: 4 additions & 4 deletions dist/helpers/prepare-queued-pr-for-merge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
import {
prepareQueuedPrForMerge2,
updatePrWithDefaultBranch2
} from "../main-dkmveggg.js";
} from "../main-dm1emycq.js";
import"../main-d50gcstv.js";
import"../main-b3a18pad.js";
import"../main-en73eexx.js";
import"../main-j2vhxcaz.js";
import"../main-xtctj82v.js";
import"../main-kvpz5nvm.js";
import"../main-hwzwrqja.js";
import"../main-c2rt2anc.js";
import"../main-hbnqs8ps.js";
import"../main-jq9kgsp8.js";
import"../main-33hyq3fg.js";
import"../main-8fvwf10s.js";
import"../main-zdktbbwp.js";
import"../main-h4qz490e.js";
import"../main-fh8gy58w.js";
import"../main-nnwtk8w8.js";
import"../main-6sabwhac.js";
Expand Down
2 changes: 1 addition & 1 deletion dist/main-dkmveggg.js → dist/main-dm1emycq.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import {
} from "./main-hwzwrqja.js";
import {
approvalsSatisfied2
} from "./main-xtctj82v.js";
} from "./main-kvpz5nvm.js";
import {
isUserInTeam2
} from "./main-d50gcstv.js";
Expand Down
0 dist/main-dkmveggg.js.map → dist/main-dm1emycq.js.map
View file
Open in desktop
File renamed without changes.
7 changes: 5 additions & 2 deletions dist/main-8fvwf10s.js → dist/main-h4qz490e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,11 @@ var getChangedFilepathsFromShas = async (before, after, ignore_deleted) => {
return extractFilepaths(Array.from(fileMap.values()), ignore_deleted);
};
var extractFilepaths = (changedFiles, ignore_deleted) => {
const renamedPreviousFilenames = changedFiles.filter(({ status }) => status === "renamed").map(({ previous_filename }) => previous_filename).filter(Boolean);
const processedFilenames = (ignore_deleted ? changedFiles.filter(({ status }) => status !== "removed") : changedFiles).map(({ filename }) => filename);
if (ignore_deleted) {
return processedFilenames;
}
const renamedPreviousFilenames = changedFiles.filter(({ status }) => status === "renamed").map(({ previous_filename }) => previous_filename).filter(Boolean);
return processedFilenames.concat(renamedPreviousFilenames);
};
var paginateAllCommitsInRange = async (before, after, page = 1) => {
Expand Down Expand Up @@ -56,4 +59,4 @@ var paginateAllChangedFilepaths = async (pull_number, page = 1) => {

export { getChangedFilepaths, getChangedFilepathsFromShas };

//# debugId=BC6FAEACD395161564756E2164756E21
//# debugId=6C9A16D8E7B2F99F64756E2164756E21
6 changes: 3 additions & 3 deletions dist/main-8fvwf10s.js.map → dist/main-h4qz490e.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/main-xtctj82v.js → dist/main-kvpz5nvm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
import {
paginateMembersInOrg,
getRequiredCodeOwnersEntries
} from "./main-33hyq3fg.js";
} from "./main-zdktbbwp.js";
import {
createPrComment2
} from "./main-hwzwrqja.js";
Expand Down
0 dist/main-xtctj82v.js.map → dist/main-kvpz5nvm.js.map
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion dist/main-33hyq3fg.js → dist/main-zdktbbwp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from "./main-nnwtk8w8.js";
import {
getChangedFilepaths
} from "./main-8fvwf10s.js";
} from "./main-h4qz490e.js";
import {
require_lodash
} from "./main-t2wes6yn.js";
Expand Down
0 dist/main-33hyq3fg.js.map → dist/main-zdktbbwp.js.map
View file
Open in desktop
File renamed without changes.
9 changes: 6 additions & 3 deletions src/utils/get-changed-filepaths.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,16 @@ export const getChangedFilepathsFromShas = async (before: string, after: string,
};

const extractFilepaths = (changedFiles: ChangedFilesList, ignore_deleted?: boolean) => {
const processedFilenames = (ignore_deleted ? changedFiles.filter(({ status }) => status !== 'removed') : changedFiles).map(
({ filename }) => filename
);
if (ignore_deleted) {
return processedFilenames;
}
const renamedPreviousFilenames = changedFiles
.filter(({ status }) => status === 'renamed')
.map(({ previous_filename }) => previous_filename)
.filter(Boolean); // GitHub should always include previous_filename for renamed files, but just in case
const processedFilenames = (ignore_deleted ? changedFiles.filter(({ status }) => status !== 'removed') : changedFiles).map(
({ filename }) => filename
);
return processedFilenames.concat(renamedPreviousFilenames);
};

Expand Down
11 changes: 10 additions & 1 deletion test/helpers/get-changed-files.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,20 @@ describe('getChangedFiles', () => {
(octokit.pulls.listFiles as unknown as Mock<any>).mockImplementation(async ({ page }: { page: number }) => ({
data: page === 1 ? mock_data4 : []
}));
const result = await getChangedFiles({ ignore_deleted: 'true' });
const result = await getChangedFiles({});

expect(result).toEqual([mock_data4[0].filename, mock_data4[1].filename, mock_data4[1].previous_filename].join(','));
});

it('should exclude original location of renamed files when ignore_deleted input is provided', async () => {
(octokit.pulls.listFiles as unknown as Mock<any>).mockImplementation(async ({ page }: { page: number }) => ({
data: page === 1 ? mock_data4 : []
}));
const result = await getChangedFiles({ ignore_deleted: 'true' });

expect(result).toEqual([mock_data4[0].filename, mock_data4[1].filename].join(','));
});

it('should handle merge queue case', async () => {
context.eventName = 'merge_group';
context.ref = 'refs/heads/gh-readonly-queue/default-branch/pr-12345-f0d9a4cb862b13cdaab6522f72d6dc17e4336b7f';
Expand Down
Loading