Delete cmake/msvc_conan_profiles - #9479
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Repository documentation still references these MSVC profile files for Windows/Visual Studio Conan builds, so removing them without updating the docs will leave broken build instructions.
Review tier: Lite
Findings: None
What changed in this PR
This PR removes the legacy MSVC Conan profile files under cmake/msvc_conan_profiles/, with the stated intent of cleaning up unused Conan-1-related artifacts ahead of the planned Conan 2 upgrade (see #9460).
Changes:
- Removes MSVC Conan profile definitions for Visual Studio 2008–2019 (Debug/Release, 32/64-bit variants).
- Eliminates a set of profile presets that were previously intended to be copied into
%HOMEPATH%\.conan\profilesfor Windows builds.
| File | Description |
|---|---|
| cmake/msvc_conan_profiles/msvc2019Release64 | Removes VS2019 Release x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2019Release32 | Removes VS2019 Release x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2019Release | Removes VS2019 Release (generic) Conan profile |
| cmake/msvc_conan_profiles/msvc2019Debug64 | Removes VS2019 Debug x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2019Debug32 | Removes VS2019 Debug x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2019Debug | Removes VS2019 Debug (generic) Conan profile |
| cmake/msvc_conan_profiles/msvc2017Release64 | Removes VS2017 Release x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2017Release32 | Removes VS2017 Release x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2017Debug64 | Removes VS2017 Debug x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2017Debug32 | Removes VS2017 Debug x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2015Release64 | Removes VS2015 Release x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2015Release32 | Removes VS2015 Release x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2015Debug64 | Removes VS2015 Debug x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2015Debug32 | Removes VS2015 Debug x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2013Release64 | Removes VS2013 Release x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2013Release32 | Removes VS2013 Release x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2013Debug64 | Removes VS2013 Debug x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2013Debug32 | Removes VS2013 Debug x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2012Release64 | Removes VS2012 Release x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2012Release32 | Removes VS2012 Release x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2012Debug64 | Removes VS2012 Debug x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2012Debug32 | Removes VS2012 Debug x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2010Release64 | Removes VS2010 Release x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2010Release32 | Removes VS2010 Release x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2010Debug64 | Removes VS2010 Debug x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2010Debug32 | Removes VS2010 Debug x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2008Release64 | Removes VS2008 Release x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2008Release32 | Removes VS2008 Release x86 Conan profile |
| cmake/msvc_conan_profiles/msvc2008Debug64 | Removes VS2008 Debug x64 Conan profile |
| cmake/msvc_conan_profiles/msvc2008Debug32 | Removes VS2008 Debug x86 Conan profile |
Suppressed comments (1)
cmake/msvc_conan_profiles/msvc2019Release64:1
- These MSVC Conan profile files are referenced by the repository documentation (e.g., README-CONAN.md recommends using profiles from
cmake/msvc_conan_profilesand showsconan install .. --profile msvc2019Release64; README.md shows--profile msvc2019Release). Removing the profiles without updating those docs will leave broken Windows build instructions; either update the docs to remove/replace the profile references or keep the profiles until the Conan-2 migration updates the documentation.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kevinbackhouse
marked this pull request as ready for review
September 4, 2026 12:21
Collaborator
|
How about removing those mentions in the readmes as well? Edit: Nevervmind, the readme willll get updated anyway with the swicth... |
kmilos
approved these changes
Sep 4, 2026
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files aren't used. And because they're related to conan, it's best to delete them before we upgrade to conan 2 (see #9460).