Skip to content

Include previously implicit header - #9473

Merged
kmilos merged 1 commit into
Exiv2:mainfrom
parona-source:transient-header
Sep 1, 2026
Merged

Include previously implicit header#9473
kmilos merged 1 commit into
Exiv2:mainfrom
parona-source:transient-header

Conversation

@parona-source

Copy link
Copy Markdown
Contributor
  • Needed for std::mktime which previously worked via implicit headers. Libcxx-23 has pruned these so its needed explicitly now.
/home/ask/sources/exiv2/src/value.cpp:850:33: error: no member named 'mktime' in namespace 'std'; did
      you mean simply 'mktime'?
  850 |   auto l = static_cast<int64_t>(std::mktime(&tms));
      |                                 ^~~~~~~~~~~
      |                                 mktime
/usr/include/time.h:91:15: note: 'mktime' declared here
   91 | extern time_t mktime (struct tm *__tp) __THROW;
      |               ^

See also: https://discourse.llvm.org/t/rfc-remove-unused-transitive-includes-from-the-libc-headers/90157

* Needed for std::mktime which previously worked via implicit headers.
  Libcxx-23 has pruned these so its needed explicitly now.

Signed-off-by: Alfred Wingate <parona@protonmail.com>

@kmilos kmilos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@mergify

mergify Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@kmilos kmilos added the compilers Related with compiler options, definitions, support, etc. label Sep 1, 2026
@kmilos kmilos added this to the v0.29.0 milestone Sep 1, 2026
@kmilos
kmilos merged commit 7fd89e7 into Exiv2:main Sep 1, 2026
76 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compilers Related with compiler options, definitions, support, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants