Add a -p j print mode that outputs Exif, IPTC, and XMP metadata as pretty-printed JSON. - #9365
Open
dixflatlinr wants to merge 3 commits into
Open
Add a -p j print mode that outputs Exif, IPTC, and XMP metadata as pretty-printed JSON.#9365dixflatlinr wants to merge 3 commits into
dixflatlinr wants to merge 3 commits into
Conversation
- New Print::printJson() method reads image metadata and serializes it with nlohmann::ordered_json. - buildMetadatumJson() handles per-tag JSON construction - serializeMetadataJson() template filters containers by the same grep/key/unknown flags used by the existing printMetadata() path.
- TestJsonBasicStructure: validates top-level keys, per-tag field presence and types on DSC_3079.jpg - TestJsonFileNotFound: verifies correct stderr message and retval=255 for missing files - TestJsonWithGrepFilter: -g flag restricts tags to matching keys - TestJsonWithKeyFilter: -K flag limits output to exact key (ordered -K before -p j to work around printMode_=pmList side-effect at exiv2.cpp:394) - TestJsonWithGrepNoMatch: grep with no hits produces empty arrays - TestJsonIsValidJson: smoke test that stdout is parseable JSON
Collaborator
|
@kmilos: I like this idea of a JSON output mode, because it could be useful for piping Exiv2's output into other tools. What do you think? |
kmilos
reviewed
Sep 4, 2026
Comment on lines
+90
to
+96
| include(FetchContent) | ||
| FetchContent_Declare(nlohmann_json | ||
| GIT_REPOSITORY https://github.com/nlohmann/json.git | ||
| GIT_TAG v3.11.3 | ||
| ) | ||
| FetchContent_MakeAvailable(nlohmann_json) | ||
| message(STATUS "nlohmann_json: fetched from GitHub") |
Collaborator
There was a problem hiding this comment.
Pretty please, no FetchContent.
Collaborator
|
@kevinbackhouse Sure, if it works the same or better than the removed exiv2json... However I have limited bandwidth to test the feature. P.S. Please don't merge main branch into PRs, the OP should be asked to rebase instead. |
Collaborator
Sorry about that. I wanted to run the tests, and that seemed to be the easiest way to trigger them. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| static nlohmann::ordered_json buildMetadatumJson(const Exiv2::Metadatum& md, const Exiv2::Image* pImage) { | ||
| nlohmann::ordered_json j; | ||
|
|
||
| j["key"] = md.key(); |
| nlohmann::ordered_json j; | ||
|
|
||
| j["key"] = md.key(); | ||
| j["group"] = md.groupName(); |
|
|
||
| j["key"] = md.key(); | ||
| j["group"] = md.groupName(); | ||
| j["name"] = md.tagName(); |
| j["key"] = md.key(); | ||
| j["group"] = md.groupName(); | ||
| j["name"] = md.tagName(); | ||
| j["label"] = md.tagLabel(); |
| j["group"] = md.groupName(); | ||
| j["name"] = md.tagName(); | ||
| j["label"] = md.tagLabel(); | ||
| j["tag"] = md.tag(); |
|
|
||
| nlohmann::ordered_json root; | ||
|
|
||
| root["file"] = path_; |
| nlohmann::ordered_json root; | ||
|
|
||
| root["file"] = path_; | ||
| root["mime"] = image->mimeType(); |
|
|
||
| root["file"] = path_; | ||
| root["mime"] = image->mimeType(); | ||
| root["imageWidth"] = image->pixelWidth(); |
| root["file"] = path_; | ||
| root["mime"] = image->mimeType(); | ||
| root["imageWidth"] = image->pixelWidth(); | ||
| root["imageHeight"] = image->pixelHeight(); |
| root["mime"] = image->mimeType(); | ||
| root["imageWidth"] = image->pixelWidth(); | ||
| root["imageHeight"] = image->pixelHeight(); | ||
| root["comment"] = image->comment(); |
Collaborator
As maintainer/admin you also have the option to rebase rather than merge. (But it is better/nicer the OP keeps their local branch rebased if possible...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.