fix(antigravity): preserve commands with colliding names - #1673
Open
22nsuk wants to merge 1 commit into
Open
Conversation
Use the path returned by the existing uniqueName helper so normalized command names cannot overwrite earlier prompts. Keep namespaces and non-colliding paths unchanged. Cover flat and namespaced converter-to-writer output, including an already occupied numeric suffix and preservation of each prompt. Fixes EveryInc#1672.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1672.
Use the path returned by the existing
uniqueName()helper so normalized command-name collisions do not overwrite earlier prompts. Namespace layout and non-colliding paths stay unchanged.Validation
Two converter-to-writer regression cases cover flat/namespaced commands, an occupied
-2suffix, and each output's prompt. Both fail before the fix. All 8 writer cases pass locally using Node 22.16.0 with a TypeScript/assertion adapter; native Bun and the full suite are left to CI.Security Disclosure
Output-integrity fix only. No changes to permissions, path validation, or skill-directory handling.
Agent Disclosure
ChatGPT · GPT-6 Astra Pro.