Skip to content

[18.0][IMP] tier_validation_dynamic_state: check for valid tiers instead search only by states #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcelsavegnago merged 1 commit into from
Apr 14, 2026
Merged

[18.0][IMP] tier_validation_dynamic_state: check for valid tiers instead search only by states #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tier_validation_dynamic_state/models/tier_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,9 @@ def _check_and_request_tier(self, target_state):
],
)
)
valid_tiers = any([self.evaluate_tier(tier) for tier in tier_definitions])

if not tier_definitions:
if not valid_tiers:
return False

current_reviews = self.review_ids.filtered(
Expand Down
9 changes: 9 additions & 0 deletions tier_validation_dynamic_state/tests/test_tier_validation_dynamic_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,12 @@ def test_prepare_tier_review_vals(self):
vals = self.test_record._prepare_tier_review_vals(self.tier_def_1, 1)
self.assertEqual(vals["state_from"], "draft")
self.assertEqual(vals["state_to"], "confirmed")

def test_check_and_request_tier_no_definition(self):
record = self.test_record

res = record._check_and_request_tier("cancel")
self.assertFalse(res)

record.write({"state": "cancel"})
self.assertEqual(record.state, "cancel")
Loading