Repository navigation
Fix: CLI test independent of line endings (Windows) - #7
Merged
Merged
Conversation
Windows checks the example scenes out with CRLF, so removing a line by matching it with "\n" did nothing and the test saw an emergency output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
a_luminaire_without_emergency_output_is_reported_not_guessedremoved the example's emergency line by matching it with\n. Windows checks text out with CRLF, so on the first hosted Windows run (now free, since the repository is public) nothing was removed and the test failed. It now drops the line whatever the line ends, and asserts the line was there.How you verified it
Life safety, never panic, provenance
Records