fix(native): build without macOS WebGPU callbacks - #620
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harness: Codex
Agent: none
Model: gpt-6-astra
Task statements
main. (Working-directory and workflow instructions omitted.)The macOS WebGPU transport is now registered only on macOS. Linux and Windows builds no longer ask N-API to register callbacks whose implementations were compiled out. The direct WebGPU benchmark examples also report that they are macOS-only instead of compiling against unavailable dependencies.
The React transport treats the submission method as optional. When a platform does not export it,
canvas.getContext("webgpu")returnsnull.mainE0425for the cfg-removedcreate_web_gpu_*_c_callbackfunctionsRUST_FONTCONFIG_DLOPEN=1 cargo check --target x86_64-unknown-linux-gnu --no-default-features --all-targetsWindows is not cross-compilable from this Mac without its SDK. The PR's Linux CI job is the failed check that verifies the fix, and the requested cross-platform run will cover Windows natively.
The change only affects the experimental WebGPU canvas transport off macOS. Reverting the commit restores the previous platform surface; no stored data changes.