Skip to content

Simplify arg checking#6

Open
Bisaloo wants to merge 7 commits into
EricMarcon:masterfrom
Bisaloo:simplify-arg-checking
Open

Simplify arg checking#6
Bisaloo wants to merge 7 commits into
EricMarcon:masterfrom
Bisaloo:simplify-arg-checking

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Jul 22, 2026

Copy link
Copy Markdown

I'm not 100% sure of everything so please double check but:

  • is_integer_values() already returns a single value
  • check_argument should be just TRUE or FALSE so any() is unnecessary
  • it is faster to only run tests on diag() than on the full matrix

Related to openjournals/joss-reviews#10860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant