Repository navigation
fix(benchmark): replace a kept cell holding read-only git files on retry - #24
Merged
Merged
Conversation
On Windows a retried cell's earlier workspace holds read-only git objects. rmtree(ignore_errors=True) left it behind, so the move nested the new workspace and raised 'Destination path already exists', which skipped the retry and stranded the paid session. Remove read-only files, and raise if a leftover stays.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes a Windows failure in the benchmark's retry: a retried cell raised
Destination path ... already exists, skipped the retry and stranded its session in the scratch directory, which the run deletes at the end. Onlybenchmarks/agentic/run.pychanges. No rule text, scoring or retry policy changes, and no paid session has run.Cause:
_oneremoved the kept workspace of the failed attempt withshutil.rmtree(..., ignore_errors=True). That workspace holds a git repository from_git_snapshot, whose objects are read-only, and Windows will not delete a read-only file. The delete failed silently, soshutil.movenested the new workspace inside the old directory._keep_cellnow removes the old directory, clearing the read-only flag when needed, raises if anything remains, then moves. Seen in the first live pilot attempt on 31 October, where 2 cells failed this way.Evidence
keep cellprintsXXon Windows (Python 3.15).After: it prints
ok.run.py --selftestpasses at this head, with the new case.node --test tests/*.test.jsgives 154 passed, 2 failed, 4 skipped, the same as onmain(the 2 arecorrectness.test.js: email bare unfenced code, csv timeout; cause not established).Merge danger
Door: two-way. Blast radius: benchmarks
Only the harness's cell storage changes.
Unverified