Repository navigation
Run packaging lint on every pull request - #29
Merged
Merged
Conversation
main requires its checks, so a pull request outside the path filter could never merge.
ryanduguid
enabled auto-merge (squash)
October 31, 2026 01:42
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Packaging lint now runs on every pull request.
mainrequireslint / lintandWindows installation policy (no app build), and the path filter meant neither reported on a pull request outside it, so that pull request could never merge.pull_request: - paths: [".github/workflows/**", "packaging/**", "assets/app-icon/**"]The push trigger keeps its filter.
Evidence
BLOCKED.main.actionlinton the changed workflow exits 0. Recent runs of this workflow took about 45 to 75 seconds, which is the added cost on each pull request that used to skip it.Merge danger
Door: two-way. Blast radius: CI.
Unverified
The checks on an asset-only pull request, until #28 runs them. This fork's workflow now differs from upstream's, which the fork sync may need to carry.