Repository navigation
Build releases from this fork's own workflow and register under its own names - #26
Merged
Merged
Conversation
…indow and uninstall
…nto ryan/release-workflow-2026-10-31 # Conflicts: # PATCHES.md
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Gives the fork its own release pipeline and its own Windows registration, so a first release no longer depends on
storytold/craft-common-actionsat a mutable reference or shares registry state with upstream. Stacked on #25: merge that first..github/workflows/release.yml: written afresh, unsigned Windows (x64, x86, arm64), Linux (x86_64, aarch64) and ad-hoc signed macOS universal. Refuses a published or moved tag.packaging/windows/pdfcraft.wxs,install-policy.json:PlutarchPages.Document,.Edit,.CreatePdfand theRegisteredApplicationsname, with new context-menu component GUIDs.packaging/windows/test-install.ps1: installs the x64 MSI on the runner, runs the CLI, requires a window, uninstalls and checks what's left.Evidence
Before: dry run
41101087383: 6 of 7 jobs passed, x64 failed on a bug in the new test.After: dry run
41111539740on33f9d788: all 7 jobs passed, andtest-install-policy.ps1passes locally for x64, x86 and arm64.cargo deny checkpasses.The tag lookup was run by hand: an absent tag, a present tag, a prefix-only match and a missing repository each behaved as intended.
Alcuin review: rounds 1 and 2 returned changes, all addressed or declined with reasons; round 3 approved
606c7ace.Merge danger
Door: two-way. Nothing publishes until someone pushes
release, and then only a draft. Blast radius: CI, Windows installer.The Windows registration names are fixed once a release ships: changing them later needs migration. Installing alongside upstream isn't supported, as
App Paths\pdfcraft.exeandApplications\pdfcraft.exestay shared.Unverified
draftjob and its tag check haven't run: only a push toreleasereaches them. An annotated tag and a 5xx response weren't tried.606c7acewas still running when this opened. That commit changes only thedraftjob, which it skips.--version.