Skip to content

fix(rewrite): route yadm to rtk yadm instead of the project's git repository - #20

Merged
ryanduguid merged 2 commits into
developfrom
ryan/competitor-survivors
Oct 30, 2026
Merged

ryanduguid merged 2 commits into
developfrom
ryan/competitor-survivors

Conversation

@ryanduguid

Copy link
Copy Markdown
Collaborator

Summary

yadm commands now rewrite to rtk yadm instead of rtk git, so they act on the dotfiles repository rather than the current project's repository.

- yadm status -> rtk git status
+ yadm status -> rtk yadm status

Credit: kylehgc/rtk 1d672725 by RawNuke (Apache-2.0).

Evidence

  • Before: the 5 new yadm tests fail against the unfixed rule.
  • After: the 5 yadm tests, clippy, fmt and build pass. rtk rewrite gives rtk yadm for the cd, env-prefix, compound and -C forms.
  • Full suite: 4411 passed, 1 failed. core::stream::tests::test_read_lines_lossy_preserves_lines_after_invalid_utf8 failed the same way on Windows before this change.

Merge danger

Door: two-way. Blast radius: yadm users

Unverified

  • Not run against a real yadm repository; the route was confirmed with a fake yadm on PATH.
  • sudo yadm is not rewritten.
  • rtk discover lists yadm status as unhandled, as it does for every TOML-filter-only command such as jq. The README states this.

yadm manages a separate dotfiles repository, so rewriting its subcommands to
rtk git ran git on whatever project the shell was in. Remove yadm from the git
rule; the yadm filter already routes it to the yadm binary as rtk yadm.

Adapted from kylehgc/rtk 1d67272 by RawNuke (Apache-2.0), including the rule
change and tests. Its bare git add change is not included. See rtk-ai#3408.
Say yadm left the git rewrite rule rather than claiming it can never be
rewritten, and that discover lists it as unhandled like other commands with only
a TOML filter.
@ryanduguid
ryanduguid enabled auto-merge (squash) October 30, 2026 13:13
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@ryanduguid
ryanduguid merged commit 9afa2e0 into develop Oct 30, 2026
22 of 23 checks passed
@ryanduguid
ryanduguid deleted the ryan/competitor-survivors branch October 30, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant