Repository navigation
ci(snyk): install the prebuilt cargo-cyclonedx instead of compiling it - #31
Merged
Merged
Conversation
taiki-e/install-action fetches cargo-cyclonedx 0.5.9 (the same version) as a release binary whose checksum its manifest pins, with no fallback to a source build. Compiling it took about 72 seconds of each Snyk run.
|
EquityBot
enabled auto-merge (squash)
November 2, 2026 14:22
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
✅ No blocking issues noticed
No blocking findings were identified. The workflow-specific validation scenarios remain unautomated and should be covered by CI or workflow tests.
Test suggestions
- Verify the workflow installs the requested cargo-cyclonedx version through the prebuilt install action.
- Verify installation fails rather than compiling from source when no prebuilt artifact is available.
- Verify the installed cargo-cyclonedx remains available to the subsequent SBOM generation step.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify the workflow installs the requested cargo-cyclonedx version through the prebuilt install action.
2. Verify installation fails rather than compiling from source when no prebuilt artifact is available.
3. Verify the installed cargo-cyclonedx remains available to the subsequent SBOM generation step.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



taiki-e/install-action fetches cargo-cyclonedx 0.5.9 (the same version) as a
release binary whose checksum its manifest pins, with no fallback to a
source build. Compiling it took about 72 seconds of each Snyk run.
Checked locally: actionlint (0 findings),
zizmor --offline(no new findings against the base) and a YAML parse of every workflow; install-action's manifest lists cargo-cyclonedx 0.5.9.Not verified:
ci.ymlchanges (cargo-audit prebuilt, rust-cache) wait for Dependabot #30, which edits the same file.Alcuin (GPT-6, Extra High) reviewed this change in one review of 16 CI pull requests across Ryan's repositories: APPROVE, no findings.