Repository navigation
ci: add Codecov, SonarCloud and Codacy badges - #25
Conversation
The codecov job continues on error, so a Codecov outage cannot turn the tests badge red; the upload still fails its own job.
|
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The Linux coverage workflow uses an invalid Rust component name, so the CI leg will fail before generating coverage or uploading it. This should be fixed before merging.
The SonarCloud badge still points to the former project, leaving the badge requirement unmet. Workflow behavior and badge resolution also remain unverified by automated tests.
Test suggestions
- Linux CI installs coverage tooling, runs tests under cargo-llvm-cov, and produces an LCOV artifact.
- The separate Codecov job downloads the artifact and performs an OIDC upload under the intended event and permission conditions.
- Windows CI runs the full test suite with the intended serial test-thread configuration.
- README service badges resolve to the current repository and corresponding service projects.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Linux CI installs coverage tooling, runs tests under cargo-llvm-cov, and produces an LCOV artifact.
2. The separate Codecov job downloads the artifact and performs an OIDC upload under the intended event and permission conditions.
3. Windows CI runs the full test suite with the intended serial test-thread configuration.
4. README service badges resolve to the current repository and corresponding service projects.
Low confidence findings
- Verify the updated workflow with a CI run covering coverage generation, artifact transfer, and the separate OIDC-authenticated upload job.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| - run: cargo clippy --all-targets --locked -- -D warnings | ||
| # Coverage needs llvm-tools and a prebuilt cargo-llvm-cov, with no fallback to compiling it. | ||
| - if: runner.os == 'Linux' | ||
| run: rustup component add llvm-tools |
There was a problem hiding this comment.
🔴 HIGH RISK
Use the actual rustup component name, llvm-tools-preview, so the Linux CI leg can initialize coverage tooling.
TIP React 👍 if this review is right, or reply with what's wrong and how it could be better to help improve the reviewer.
|
|
||
| [](https://github.com/EquityBot/Industrious/actions/workflows/ci.yml) [](https://github.com/EquityBot/Industrious/actions/workflows/codeql.yml) [](https://github.com/EquityBot/Alcuin/actions/workflows/snyk.yml)<br> | ||
| [](https://scorecard.dev/viewer/?uri=github.com/EquityBot/Industrious)<br> | ||
| [](https://github.com/EquityBot/Alcuin/actions/workflows/ci.yml) [](https://codecov.io/gh/EquityBot/Alcuin) [](https://github.com/EquityBot/Alcuin/actions/workflows/codeql.yml) [](https://github.com/EquityBot/Alcuin/actions/workflows/snyk.yml) [](https://sonarcloud.io/summary/new_code?id=EquityBot_Industrious) [](https://app.codacy.com/gh/EquityBot/Alcuin/dashboard)<br> |
There was a problem hiding this comment.
🟡 MEDIUM RISK
Update the SonarCloud badge URL and link to the current project's SonarCloud identifier.
TIP React 👍 if this review is right, or reply with what's wrong and how it could be better to help improve the reviewer.



Summary
Brings this repository's badges up to the maintainer's other account: Codecov coverage, a Snyk scan, SonarCloud and Codacy.
Rust tests now run under
cargo llvm-covon the Linux leg (Windows keepscargo test), and a separatecodecovjob uploads the report by OIDC. The README gains Codecov, SonarCloud and Codacy badges;codecov.ymlkeeps statuses informational; CONTRIBUTING gains a test policy.Evidence
cargo fmt --check,cargo clippy --all-targets -- -D warningsand the fullcargo testsuite: pass.Merge danger
Door: two-way. Blast radius: CI
The Codecov job continues on error, so an outage there cannot turn the tests badge red. The OIDC token is granted only to that job, never to a job that runs tests.
Unverified