Skip to content

ci: add Codecov, SonarCloud and Codacy badges - #25

Merged
EquityBot merged 2 commits into
mainfrom
ryan/badges-parity
Oct 31, 2026
Merged

EquityBot merged 2 commits into
mainfrom
ryan/badges-parity

Conversation

@EquityBot

Copy link
Copy Markdown
Owner

Summary

Brings this repository's badges up to the maintainer's other account: Codecov coverage, a Snyk scan, SonarCloud and Codacy.

Rust tests now run under cargo llvm-cov on the Linux leg (Windows keeps cargo test), and a separate codecov job uploads the report by OIDC. The README gains Codecov, SonarCloud and Codacy badges; codecov.yml keeps statuses informational; CONTRIBUTING gains a test policy.

Evidence

  • cargo fmt --check, cargo clippy --all-targets -- -D warnings and the full cargo test suite: pass.
  • actionlint and zizmor: clean.

Merge danger

Door: two-way. Blast radius: CI

The Codecov job continues on error, so an outage there cannot turn the tests badge red. The OIDC token is granted only to that job, never to a job that runs tests.

Unverified

  • The changed workflows have not run yet; this PR's own run is the first.
  • Codecov has not yet received an OIDC upload for this repository, so the first upload is unconfirmed.

The codecov job continues on error, so a Codecov outage cannot turn the
tests badge red; the upload still fails its own job.
@EquityBot
EquityBot enabled auto-merge (squash) October 31, 2026 22:37
@sonarqubecloud

Copy link
Copy Markdown

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

⚠️ Resolve issues before merging

The Linux coverage workflow uses an invalid Rust component name, so the CI leg will fail before generating coverage or uploading it. This should be fixed before merging.

The SonarCloud badge still points to the former project, leaving the badge requirement unmet. Workflow behavior and badge resolution also remain unverified by automated tests.

Test suggestions

  • Linux CI installs coverage tooling, runs tests under cargo-llvm-cov, and produces an LCOV artifact.
  • The separate Codecov job downloads the artifact and performs an OIDC upload under the intended event and permission conditions.
  • Windows CI runs the full test suite with the intended serial test-thread configuration.
  • README service badges resolve to the current repository and corresponding service projects.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Linux CI installs coverage tooling, runs tests under cargo-llvm-cov, and produces an LCOV artifact.
2. The separate Codecov job downloads the artifact and performs an OIDC upload under the intended event and permission conditions.
3. Windows CI runs the full test suite with the intended serial test-thread configuration.
4. README service badges resolve to the current repository and corresponding service projects.
Low confidence findings
  • Verify the updated workflow with a CI run covering coverage generation, artifact transfer, and the separate OIDC-authenticated upload job.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread .github/workflows/ci.yml
- run: cargo clippy --all-targets --locked -- -D warnings
# Coverage needs llvm-tools and a prebuilt cargo-llvm-cov, with no fallback to compiling it.
- if: runner.os == 'Linux'
run: rustup component add llvm-tools

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

Use the actual rustup component name, llvm-tools-preview, so the Linux CI leg can initialize coverage tooling.

TIP React 👍 if this review is right, or reply with what's wrong and how it could be better to help improve the reviewer.

Comment thread README.md

[![tests](https://github.com/EquityBot/Industrious/actions/workflows/ci.yml/badge.svg?branch=main)](https://github.com/EquityBot/Industrious/actions/workflows/ci.yml) [![CodeQL](https://github.com/EquityBot/Industrious/actions/workflows/codeql.yml/badge.svg?branch=main)](https://github.com/EquityBot/Industrious/actions/workflows/codeql.yml) [![Snyk](https://github.com/EquityBot/Alcuin/actions/workflows/snyk.yml/badge.svg?branch=main)](https://github.com/EquityBot/Alcuin/actions/workflows/snyk.yml)<br>
[![OpenSSF Scorecard](https://raw.githubusercontent.com/ryanduguid/.github/badges/EquityBot/Industrious.svg)](https://scorecard.dev/viewer/?uri=github.com/EquityBot/Industrious)<br>
[![tests](https://github.com/EquityBot/Alcuin/actions/workflows/ci.yml/badge.svg?branch=main)](https://github.com/EquityBot/Alcuin/actions/workflows/ci.yml) [![Codecov](https://codecov.io/gh/EquityBot/Alcuin/graph/badge.svg)](https://codecov.io/gh/EquityBot/Alcuin) [![CodeQL](https://github.com/EquityBot/Alcuin/actions/workflows/codeql.yml/badge.svg?branch=main)](https://github.com/EquityBot/Alcuin/actions/workflows/codeql.yml) [![Snyk](https://github.com/EquityBot/Alcuin/actions/workflows/snyk.yml/badge.svg?branch=main)](https://github.com/EquityBot/Alcuin/actions/workflows/snyk.yml) [![SonarCloud](https://sonarcloud.io/api/project_badges/measure?project=EquityBot_Industrious&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=EquityBot_Industrious) [![Codacy code quality](https://app.codacy.com/project/badge/Grade/64b01c5d3b174763951ce4fa40124a84)](https://app.codacy.com/gh/EquityBot/Alcuin/dashboard)<br>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Update the SonarCloud badge URL and link to the current project's SonarCloud identifier.

TIP React 👍 if this review is right, or reply with what's wrong and how it could be better to help improve the reviewer.

@EquityBot
EquityBot merged commit 6d26687 into main Oct 31, 2026
13 checks passed
@EquityBot
EquityBot deleted the ryan/badges-parity branch October 31, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants