Repository navigation
Conversation
A weekly Snyk workflow tests the Cargo dependencies through CycloneDX SBOMs and the npm lockfiles directly. It needs the SNYK_TOKEN repository secret.
|
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The Snyk badge currently references a different repository, so it does not report this project's workflow status and should be corrected before merging.
The required workflow and badge behaviors have no automated validation coverage; in particular, failure paths and event triggers remain unverified.
Test suggestions
- Verify scheduled, manual, dependency-change, and workflow-change triggers
- Verify SBOM files are generated and each is scanned with Snyk
- Verify the job fails when
SNYK_TOKENis absent - Verify the job fails when SBOM generation or Snyk scanning fails
- Verify the README Snyk badge links to this repository's workflow
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify scheduled, manual, dependency-change, and workflow-change triggers
2. Verify SBOM files are generated and each is scanned with Snyk
3. Verify the job fails when `SNYK_TOKEN` is absent
4. Verify the job fails when SBOM generation or Snyk scanning fails
5. Verify the README Snyk badge links to this repository's workflow
Low confidence findings
- Add automated validation for the workflow's triggers, SBOM/scanning failure paths, missing-secret behavior, and badge target.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| <div align="center"> | ||
|
|
||
| [](https://github.com/EquityBot/Industrious/actions/workflows/ci.yml) [](https://github.com/EquityBot/Industrious/actions/workflows/codeql.yml)<br> | ||
| [](https://github.com/EquityBot/Industrious/actions/workflows/ci.yml) [](https://github.com/EquityBot/Industrious/actions/workflows/codeql.yml) [](https://github.com/EquityBot/Alcuin/actions/workflows/snyk.yml)<br> |
There was a problem hiding this comment.
🟡 MEDIUM RISK
Point both Snyk badge URLs at this repository's .github/workflows/snyk.yml so the badge reports this project's workflow status.
TIP React 👍 if this review is right, or reply with what's wrong and how it could be better to help improve the reviewer.



Summary
Adds a Snyk dependency test and its badge, next to CodeQL. Snyk tests Rust only through
snyk sbom test, so each Cargo workspace is described as CycloneDX SBOMs (one per member) and each is tested; npm lockfiles are tested directly.It runs weekly, on manual dispatch and when a lockfile or the workflow changes. It fails when
SNYK_TOKENis missing, an SBOM cannot be generated or Snyk reports an issue.Evidence
Merge danger
Door: two-way. Blast radius: CI
The Snyk job fails until the
SNYK_TOKENrepository secret is set; then rerun it.Unverified