Skip to content

Test dependencies with Snyk and show its badge - #24

Merged
EquityBot merged 1 commit into
mainfrom
ryan/snyk
Oct 31, 2026
Merged

EquityBot merged 1 commit into
mainfrom
ryan/snyk

Conversation

@ryanduguid

Copy link
Copy Markdown
Collaborator

Summary

Adds a Snyk dependency test and its badge, next to CodeQL. Snyk tests Rust only through snyk sbom test, so each Cargo workspace is described as CycloneDX SBOMs (one per member) and each is tested; npm lockfiles are tested directly.

SNYK_TARGETS
cargo:.

It runs weekly, on manual dispatch and when a lockfile or the workflow changes. It fails when SNYK_TOKEN is missing, an SBOM cannot be generated or Snyk reports an issue.

Evidence

  • actionlint: no findings.
  • The workflow follows the Snyk workflows that ran in Ryan's other repositories, with the same action pins.

Merge danger

Door: two-way. Blast radius: CI

The Snyk job fails until the SNYK_TOKEN repository secret is set; then rerun it.

Unverified

  • A Snyk scan has not run: the secret is not set yet.
  • Snyk's free-plan test allowance for these tests was not checked.

A weekly Snyk workflow tests the Cargo dependencies through CycloneDX SBOMs
and the npm lockfiles directly. It needs the SNYK_TOKEN repository secret.
@sonarqubecloud

Copy link
Copy Markdown

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

⚠️ Resolve issues before merging

The Snyk badge currently references a different repository, so it does not report this project's workflow status and should be corrected before merging.

The required workflow and badge behaviors have no automated validation coverage; in particular, failure paths and event triggers remain unverified.

Test suggestions

  • Verify scheduled, manual, dependency-change, and workflow-change triggers
  • Verify SBOM files are generated and each is scanned with Snyk
  • Verify the job fails when SNYK_TOKEN is absent
  • Verify the job fails when SBOM generation or Snyk scanning fails
  • Verify the README Snyk badge links to this repository's workflow
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify scheduled, manual, dependency-change, and workflow-change triggers
2. Verify SBOM files are generated and each is scanned with Snyk
3. Verify the job fails when `SNYK_TOKEN` is absent
4. Verify the job fails when SBOM generation or Snyk scanning fails
5. Verify the README Snyk badge links to this repository's workflow
Low confidence findings
  • Add automated validation for the workflow's triggers, SBOM/scanning failure paths, missing-secret behavior, and badge target.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread README.md
<div align="center">

[![tests](https://github.com/EquityBot/Industrious/actions/workflows/ci.yml/badge.svg?branch=main)](https://github.com/EquityBot/Industrious/actions/workflows/ci.yml) [![CodeQL](https://github.com/EquityBot/Industrious/actions/workflows/codeql.yml/badge.svg?branch=main)](https://github.com/EquityBot/Industrious/actions/workflows/codeql.yml)<br>
[![tests](https://github.com/EquityBot/Industrious/actions/workflows/ci.yml/badge.svg?branch=main)](https://github.com/EquityBot/Industrious/actions/workflows/ci.yml) [![CodeQL](https://github.com/EquityBot/Industrious/actions/workflows/codeql.yml/badge.svg?branch=main)](https://github.com/EquityBot/Industrious/actions/workflows/codeql.yml) [![Snyk](https://github.com/EquityBot/Alcuin/actions/workflows/snyk.yml/badge.svg?branch=main)](https://github.com/EquityBot/Alcuin/actions/workflows/snyk.yml)<br>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Point both Snyk badge URLs at this repository's .github/workflows/snyk.yml so the badge reports this project's workflow status.

TIP React 👍 if this review is right, or reply with what's wrong and how it could be better to help improve the reviewer.

@EquityBot
EquityBot merged commit 34b4f7c into main Oct 31, 2026
13 of 14 checks passed
@EquityBot
EquityBot deleted the ryan/snyk branch October 31, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants