Add length and cumulative lengths to RoadMapElement#425
Open
vcharraut wants to merge 1 commit into
Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Pull request overview
Adds support for lane length metadata in the Drive binary map loader for 123Drive v0.3.
Changes:
- Adds
lengthandcum_lengthsfields toRoadMapElement. - Reads lane length metadata from map binaries.
- Uses precomputed cumulative lengths for remaining lane distance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pufferlib/ocean/drive/drive.h |
Updates binary loading and lane distance calculations. |
pufferlib/ocean/drive/datatypes.h |
Extends road and lane graph data structures and cleanup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1206
to
+1211
| if (fread(&road->length, sizeof(float), 1, file) != 1) { | ||
| fclose(file); | ||
| return -1; | ||
| } | ||
| road->cum_lengths = (float *)malloc(slen * sizeof(float)); | ||
| if ((size_t)slen > 0 && fread(road->cum_lengths, sizeof(float), slen, file) != (size_t)slen) { |
Comment on lines
+1441
to
+1443
| float progress = lane->cum_lengths[closest_seg] + | ||
| closest_t * (lane->cum_lengths[closest_seg + 1] - lane->cum_lengths[closest_seg]); | ||
| return fmaxf(0.0f, lane->length - progress); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for v0.3 123Drive