Skip to content

engine: Service timeout shutdown - #1919

Merged
DanCodedThis merged 4 commits into
mainfrom
DanCodedThis/1896-timeout-shutdown
Nov 13, 2025
Merged

engine: Service timeout shutdown#1919
DanCodedThis merged 4 commits into
mainfrom
DanCodedThis/1896-timeout-shutdown

Conversation

@DanCodedThis

@DanCodedThis DanCodedThis commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Closes #1896

  • Adds new cli option: IDLE_TIMEOUT_SECONDS with default value of 18000 (5 hours)
  • Adds new timeout_signal fn is a execution service
  • The function is done similar to the session expiration and other shutdown signals
  • The function is then used in tokio select of graceful shutdown of the axum::serve in main
  • Adds an expiration time test
  • Interval and idle timeout now are different numbers, to avoid bugs written below

@github-actions

Copy link
Copy Markdown
Contributor

SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required.

@DanCodedThis
DanCodedThis marked this pull request as draft November 12, 2025 10:49
@DanCodedThis

DanCodedThis commented Nov 12, 2025

Copy link
Copy Markdown
Contributor Author

The timer check interval and the idle timeout should be two different numbers, where if one queries some time ago and then on the second looses his last session when the check happens it shouldn't shut down since the use was recent

@github-actions

Copy link
Copy Markdown
Contributor

SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required.

@DanCodedThis
DanCodedThis marked this pull request as ready for review November 12, 2025 13:53
@DanCodedThis
DanCodedThis merged commit 80c04c1 into main Nov 13, 2025
7 checks passed
@DanCodedThis
DanCodedThis deleted the DanCodedThis/1896-timeout-shutdown branch November 13, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exit the process after X minutes of inactivity

2 participants