engine: Incorrect status message fix - #1917
Merged
DanCodedThis merged 2 commits intoNov 8, 2025
Merged
Conversation
Contributor
|
✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required. |
DanCodedThis
requested review from
Vedin,
YaroslavLitvinov,
osipovartem and
rampage644
November 8, 2025 16:16
Vedin
approved these changes
Nov 8, 2025
DanCodedThis
deleted the
DanCodedThis/1916-incorrect-status-message-fix
branch
November 8, 2025 16:47
| Ok(QueryResult::new( | ||
| vec![RecordBatch::new_empty(schema.clone())], | ||
| vec
Contributor
There was a problem hiding this comment.
I actually think that this should not be fixed query executor modifying QueryResult. This "Statement executed ..." message that was added looks like belongs to a rest api. It naturally belongs to the snowflake-rest.
Contributor
There was a problem hiding this comment.
Also I believe that such change should be covered by a separate test in snowlake-rest as well
Contributor
Author
There was a problem hiding this comment.
We should probably do that later, I agree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1916
arrowwe sent an empty null array. Which resulted in a seg-fault of the snowflake clijsonwe sentNo data- an empty array.statuscolumn with a successful execution messageP.S.
Alter&Usedon't check if the variable exists (only the type I assume), so it always says it is successful, it did that before, but just didn't send the message.Dropshould check.Setis probably infallible, either, then sql "comp" errors.