Add bearer token authorization check - #1912
Merged
Merged
Conversation
Contributor
|
✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required. |
JanKaul
force-pushed
the
jankaul/bearer-token-auth
branch
from
November 7, 2025 10:48
c323d3d to
c957d02
Compare
Contributor
|
✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required. |
Contributor
|
✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required. |
JanKaul
marked this pull request as ready for review
November 7, 2025 15:19
DanCodedThis
approved these changes
Nov 7, 2025
DanCodedThis
left a comment
DanCodedThis
left a comment
Contributor
There was a problem hiding this comment.
@JanKaul How do you authorize? Or do you just send the token with each request manually, no log in? Otherwise, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add bearer token authorization for the Iceberg REST API endpoint. When configured, incoming requests are validated against the bearer token. Requests without proper authorization return 401 Unauthorized. If no token is configured, all requests are allowed through.
Changes
axum-authdependency for middleware supportrequire_authmiddleware to validate Bearer tokensbearer_tokenfield to the Iceberg REST API stateiceberg_rest_bearer_tokenCLI option (supports ICEBERG_REST_BEARER_TOKEN env var)