Prefer input columns over GROUP BY aliases - #60
Merged
osipovartem merged 1 commit intoSep 4, 2026
Conversation
osipovartem
requested review from
Vedin and
rampage644
and removed request for
rampage644
September 4, 2026 16:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
GROUP BYalias precedence on theembucket-sync-df55.0.0branch.Rationale for this change
When a bare
GROUP BYidentifier matches both an input column and a SELECT-list alias, SQL resolves it to the input column. DataFusion assembled the input and projected schemas before parsing the expression, so a qualified input field plus an unqualified alias with the same name produced a false ambiguity error.What changes are included in this PR?
GROUP BYidentifier against the input schema first when that input column is unambiguous.Are these changes tested?
Yes. Added planner tests for both directions:
SELECT SUM(id) AS age FROM person GROUP BY agegroups by the inputperson.age.SELECT state AS age FROM person GROUP BY agereaches the expected non-aggregate validation instead of a false ambiguity.Local verification:
Are there any user-facing changes?
Yes. Queries with a SELECT alias that collides with an input column now follow SQL
GROUP BYinput-column precedence. There is no public API change.