connectd: add --dev-max-wake-delay-ms - #9481
Open
Amperstrand wants to merge 1 commit into
Open
Conversation
The wake-delay watchdog (write_to_subd's empty-queue check) measures the gap between handing a peer message to the subdaemon queue and the subdaemon consuming it, which includes lightningd-master's time to spawn the subdaemon: under CI load that alone can exceed the hardcoded 5000 msec and fail runs with 'wake delay for WIRE_OPEN_CHANNEL' BROKEN (ElementsProject#9268) -- tests/test_connection.py:: test_funding_cancel_race spins up 100 nodes and hit a 11068 msec window. dev_lightningd_is_slow exists for the same class but is only settable by the memleak dev-RPC. Make the threshold a developer option (default unchanged at 5000) so load-heavy tests can raise it; wired through connectd_init. The regression test freezes the accepter's master past the default threshold and expects a clean run with the option raised. Changelog-Fixes: ElementsProject#9268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wake-delay watchdog (
write_to_subd's empty-queue check) measures the gap between handing a peer message to the subdaemon queue and the subdaemon consuming it, which includes lightningd-master's time to spawn the subdaemon: under CI load that alone can exceed the hardcoded 5000 msec and fail runs withwake delay for WIRE_OPEN_CHANNELBROKEN (#9268) — tests/test_connection.py::test_funding_cancel_race spins up 100 nodes on a fast runner and hit a 11068 msec window.dev_lightningd_is_slowexists for the same class but is only settable by the memleak dev-RPC.This makes the threshold a developer option (
--dev-max-wake-delay-ms, default unchanged at 5000) so load-heavy tests can raise it; wired throughconnectd_init. The regression test freezes the accepter's master past the default threshold and expects a clean run with the option raised.deterministic repro results (master build, regtest pyln) — expand
Fuller repro record — the trigger recipe with its two ordering traps, all cell results, and the control arm: https://gist.github.com/Amperstrand/b50c4d604f88016047e104dc65f866c6
Fixes #9268