script: reject malformed script integers, add tests - #549
Open
jgriffiths wants to merge 3 commits into
Open
Conversation
The CMake config template spelled the SHA-256 define as HAVE_MBEDTLS_SHA256_H_ (trailing underscore), so src/ccan_config.h never selected the mbedtls backend under CMake and silently built the software SHA-256 instead. The --enable-mbed-tls help string was a copy of the --enable-minimal one.
The HMAC implementation used sizeof() of a hash context member to obtain the block size and used that member as scratch space for the key block. That ties HMAC to the context layout of whichever hashing backend is selected, and is impossible for opaque backends such as PSA Crypto. Use the block size constant of the hash (64 for SHA-256, 128 for SHA-512) and a local key block instead. The byte operations are unchanged for all backends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.