Skip to content

secp: context randomize in a few places #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
delta1 wants to merge 5 commits into
base: master
Choose a base branch
from
+30 −1
Open

secp: context randomize in a few places #1594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52455af
pegin: randomize secp256k1 SIGN context in Secp256k1Ctx
delta1 Sep 1, 2026
0e7b1a6
blind: randomize secp256k1 SIGN context in Blind_ECC_Init
delta1 Sep 1, 2026
7aca707
wallet: randomize secp256k1 SIGN contexts in CSecp256k1Init
delta1 Sep 1, 2026
80e351a
confidential_validation: randomize secp256k1 SIGN context in CSecp256…
delta1 Sep 1, 2026
72a88d4
build: disable unused experimental secp256k1 zkp modules
delta1 Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,12 @@ set(SECP256K1_ENABLE_MODULE_WHITELIST ON CACHE BOOL "" FORCE)
set(SECP256K1_DISABLE_SHARED ON CACHE BOOL "" FORCE)
set(SECP256K1_ENABLE_MODULE_ECDH ON CACHE BOOL "" FORCE)
set(SECP256K1_ENABLE_MODULE_RECOVERY ON CACHE BOOL "" FORCE)
# Disable unused on-by-default features from secp256k1-zkp
set(SECP256K1_ENABLE_MODULE_MUSIG OFF CACHE BOOL "" FORCE)
set(SECP256K1_ENABLE_MODULE_BPPP OFF CACHE BOOL "" FORCE)
set(SECP256K1_ENABLE_MODULE_ECDSA_ADAPTOR OFF CACHE BOOL "" FORCE)
set(SECP256K1_ENABLE_MODULE_ECDSA_S2C OFF CACHE BOOL "" FORCE)
set(SECP256K1_ENABLE_MODULE_SCHNORRSIG_HALFAGG OFF CACHE BOOL "" FORCE)
set(SECP256K1_BUILD_BENCHMARK OFF CACHE BOOL "" FORCE)
set(SECP256K1_BUILD_TESTS ${BUILD_TESTS} CACHE BOOL "" FORCE)
set(SECP256K1_BUILD_EXHAUSTIVE_TESTS ${BUILD_TESTS} CACHE BOOL "" FORCE)
Expand Down
6 changes: 6 additions & 0 deletions src/blind.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ class Blind_ECC_Init {
secp256k1_context *ctx = secp256k1_context_create(SECP256K1_CONTEXT_SIGN | SECP256K1_CONTEXT_VERIFY);
assert(ctx != nullptr);

// Pass in a random blinding seed to the secp256k1 context (side-channel hardening,
// matching the randomization of secp256k1_context_sign in key.cpp).
unsigned char randseed[32];
GetStrongRandBytes(randseed);
assert(secp256k1_context_randomize(ctx, randseed) == 1);

secp256k1_blind_context = ctx;
}

Expand Down
6 changes: 6 additions & 0 deletions src/confidential_validation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <issuance.h>
#include <pegins.h>
#include <script/sigcache.h>
#include <random.h>
#include <blind.h>

namespace {
Expand All @@ -15,6 +16,11 @@ class CSecp256k1Init {
assert(secp256k1_ctx_verify_amounts == nullptr);
secp256k1_ctx_verify_amounts = secp256k1_context_create(SECP256K1_CONTEXT_VERIFY | SECP256K1_CONTEXT_SIGN);
assert(secp256k1_ctx_verify_amounts != nullptr);
// Pass in a random blinding seed to the secp256k1 context (side-channel hardening).
unsigned char seed[32];
GetStrongRandBytes(seed);
assert(secp256k1_context_randomize(secp256k1_ctx_verify_amounts, seed));

}
~CSecp256k1Init() {
assert(secp256k1_ctx_verify_amounts != nullptr);
Expand Down
2 changes: 1 addition & 1 deletion src/pegins.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class Secp256k1Ctx
public:
Secp256k1Ctx() {
assert(secp256k1_ctx_validation == nullptr);
secp256k1_ctx_validation = secp256k1_context_create(SECP256K1_CONTEXT_VERIFY | SECP256K1_CONTEXT_SIGN);
secp256k1_ctx_validation = secp256k1_context_create(SECP256K1_CONTEXT_NONE);
assert(secp256k1_ctx_validation != nullptr);
}

Expand Down
6 changes: 6 additions & 0 deletions src/wallet/rpc/backup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include <key_io.h>
#include <merkleblock.h>
#include <rpc/util.h>
#include <random.h>
#include <script/descriptor.h>
#include <script/script.h>
#include <script/solver.h>
Expand Down Expand Up @@ -41,6 +42,11 @@ namespace {
public:
CSecp256k1Init() {
secp256k1_ctx = secp256k1_context_create(SECP256K1_CONTEXT_VERIFY | SECP256K1_CONTEXT_SIGN);
CHECK_NONFATAL(secp256k1_ctx != nullptr);
// Pass in a random blinding seed to the secp256k1 context (side-channel hardening).
unsigned char seed[32];
GetStrongRandBytes(seed);
CHECK_NONFATAL(secp256k1_context_randomize(secp256k1_ctx, seed));
}
~CSecp256k1Init() {
secp256k1_context_destroy(secp256k1_ctx);
Expand Down
6 changes: 6 additions & 0 deletions src/wallet/rpc/elements.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#include <rpc/server.h>
#include <rpc/server_util.h>
#include <rpc/util.h>
#include <random.h>
#include <script/generic.hpp>
#include <script/pegins.h>
#include <secp256k1.h>
Expand Down Expand Up @@ -44,6 +45,11 @@ class CSecp256k1Init {
public:
CSecp256k1Init() {
secp256k1_ctx = secp256k1_context_create(SECP256K1_CONTEXT_VERIFY | SECP256K1_CONTEXT_SIGN);
CHECK_NONFATAL(secp256k1_ctx != nullptr);
// Pass in a random blinding seed to the secp256k1 context (side-channel hardening).
unsigned char seed[32];
GetStrongRandBytes(seed);
CHECK_NONFATAL(secp256k1_context_randomize(secp256k1_ctx, seed));
}
~CSecp256k1Init() {
secp256k1_context_destroy(secp256k1_ctx);
Expand Down
Loading