Repository navigation
Fix optional config typing and prepare v2.13.1 - #320
Merged
Merged
Conversation
Pyright 1.1.414 reported model_api_parameters and max_context_tokens as required for direct and TypedDict-based construction. Explicit default=None removes both errors while preserving runtime defaults. Add a focused typing check and runtime regression. Co-Authored-By: Claude Code <noreply@anthropic.com>
Bump the package version and record the verified AgentConfig typing fix. Runtime dependency requirements are unchanged. Co-Authored-By: Claude Code <noreply@anthropic.com>
Update package metadata and the verified explicit-default convention in the existing codebase map. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Declare
AgentConfig.model_api_parametersandAgentConfig.max_context_tokenswith explicitField(default=None, ...)defaults. Pyright 1.1.414 treated both positional defaults as required constructor arguments, affecting direct calls and typed settings unpacking. Runtime defaults remain unchanged.Add a focused Pyright check to CI and a runtime constructor regression. Prepare 2.13.1 with release notes and updated codebase map. Runtime requirements are unchanged. This branches from main and excludes the OpenTelemetry discovery feature in #319.
Verification
The explicit keyword default is the form recommended in Pydantic's type-checker documentation.
🤖 Generated with Claude Code