Skip to content

SCAR-84 Fix service unchanged event creation #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AttilaGombosER merged 1 commit into from
Apr 19, 2026
Merged

SCAR-84 Fix service unchanged event creation #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hello/discoverer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def _create_event(self, group: Group, matcher: ServiceMatcher, stored: Service |
return DiscoveryEvent(group, matcher.query, service, DiscoveryEventType.UPDATED)
else:
log.debug('Service unchanged', group=group, service=service)
return DiscoveryEvent(group, matcher.query, service, DiscoveryEventType.UPDATED)
return DiscoveryEvent(group, matcher.query, service, DiscoveryEventType.UNCHANGED)
else:
log.info('Service discovered', group=group, service=service)
return DiscoveryEvent(group, matcher.query, service, DiscoveryEventType.DISCOVERED)
Expand Down
6 changes: 3 additions & 3 deletions tests/defaultDiscovererTest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from hello import Service, Group, ServiceQuery, DefaultDiscoverer, Sender, Receiver, OnDiscoveryEvent, \
DiscoveryEventType, DiscoveryEvent


GROUP = Group('test-group', 'udp://239.0.0.1:5555')
SERVICE_QUERY = ServiceQuery('test-.*', 'test-.*')
SERVICE = Service(
Expand Down Expand Up @@ -185,15 +184,16 @@ def test_does_not_call_handler_when_service_not_changed(self):
discoverer = DefaultDiscoverer(sender, receiver)
discoverer.start(GROUP, SERVICE_QUERY)
handler = MagicMock(spec=OnDiscoveryEvent)
discoverer.register(handler)
discoverer.register(handler, {DiscoveryEventType.DISCOVERED, DiscoveryEventType.UPDATED})
discoverer._handle_message(SERVICE.to_dict())
handler.reset_mock()

# When
discoverer._handle_message(SERVICE.to_dict())

# Then
handler.assert_not_called()
with self.assertRaises(AssertionError):
wait_for_assertion(0.1, lambda: handler.assert_called())

def test_handles_handler_error_gracefully(self):
# Given
Expand Down
Loading