Repository navigation
docs(windows): pass build options space-separated, not semicolon-joined - #7903
Merged
Merged
Conversation
The Windows build scripts joined -D options with ';' inside one quoted value. That only worked because CollectCommandLineArgs forwarded the value unescaped and ExternalProject split it back on ';'. Since fbae719 the ';' is escaped so multi-path values stay intact, and the joined options now reach the sub-builds as a single value (e.g. "Unknown PCB 'X10 -DPCBREV=T16'"). Use space-separated options, as tools/build-common.sh does, for BUILD_OPTIONS and BUILD_TYPE, and note how to update older scripts. Also add the missing asciitree and typing_extensions to the Python package list to match pyproject.toml. Fixes EdgeTX#7900 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
added
documentation 📝
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7900
Problem
The Windows build guide told people to join
-Doptions with;inside one quoted value (set BUILD_OPTIONS="-DPCB=X10;-DPCBREV=TX16S"). cmake received that as a single argument, so the superbuild setPCBtoX10;-DPCBREV=TX16S. It only worked becauseCollectCommandLineArgsforwarded the value unescaped andExternalProjectsplit it back into separate arguments on;.#7740 (fbae719) escapes
;as|withLIST_SEPARATOR |, so multi-path values such asCMAKE_PREFIX_PATHstay one argument. That change is correct. As a side effect, the joined options now reach thenativeandarm-none-eabisub-builds as one value, and the build fails withUnknown PCB 'X10 -DPCBREV=T16 ...'.CI isn't affected, because the Windows runner builds through
tools/build-companion.sh, which passes the options space-separated.Changes (
docs/building/windows.md)BUILD_OPTIONSexample now separates options with spaces and usesset "VAR=..."quoting, so cmake gets each option as its own argument.BUILD_TYPEgets the same fix. Debug builds weren't gettingCMAKE_BUILD_TYPE=Debugfor the same reason.build-common.sh, plus a note on updating older scripts (including multi-optionPATHS).asciitreeandtyping_extensionsto theuv pip installlist to matchpyproject.toml.🤖 Generated with Claude Code