Skip to content

chore(bw): remove dead GVARS_IN_CURVES_SCREEN code - #7862

Merged
pfeerick merged 1 commit into
EdgeTX:mainfrom
pfeerick:pfeerick/remove-gvars-in-curves-screen
Oct 4, 2026
Merged

pfeerick merged 1 commit into
EdgeTX:mainfrom
pfeerick:pfeerick/remove-gvars-in-curves-screen

Conversation

@pfeerick

@pfeerick pfeerick commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Summary of changes:

Removes the GVARS_IN_CURVES_SCREEN blocks from the B&W curves screen (gui/common/stdlcd/model_curves.cpp).

  • The define has never been set anywhere in EdgeTX. The code came in with the 2016 OpenTX GUI refactor and looks like an AVR-era leftover.
  • It no longer compiles if enabled: it assigns an int from checkIncDec() to g_model.gvars[k], which is a GVarData struct.
  • B&W radios already have a dedicated global variables screen (model_gvars.cpp).

No functional change. Built for Zorro (128x64) and X9D+ 2019 (212x64).

Spotted while reviewing #7861

🤖 Generated with Claude Code

GVARS_IN_CURVES_SCREEN has never been defined in EdgeTX, and the code
behind it no longer compiles (it assigns an int to a GVarData struct).
B&W radios have a dedicated global variables screen, so drop it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pfeerick pfeerick added this to the 3.0 milestone Oct 4, 2026
@pfeerick pfeerick added the house keeping 🧹 Cleanup of code and house keeping label Oct 4, 2026
@pfeerick
pfeerick merged commit 30b13de into EdgeTX:main Oct 4, 2026
39 checks passed
@pfeerick
pfeerick deleted the pfeerick/remove-gvars-in-curves-screen branch October 24, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

house keeping 🧹 Cleanup of code and house keeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant