Skip to content

Fix EVM token swap pending metadata showing 0 #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j0ntz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix EVM token swap pending metadata showing 0 #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- fixed: (Thorchain/Maya) Show the correct from-amount in pending swap transaction metadata for EVM token swaps (e.g. USDT to ETH) instead of 0.

## 2.48.0 (2026-06-16)

- added: (Rango) Sonic support
Expand Down
12 changes: 7 additions & 5 deletions src/swap/defi/thorchain/thorchainCommon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,6 @@ export function makeThorchainBasedPlugin(
} = calcResponse
let { memo } = calcResponse

let ethNativeAmount = fromNativeAmount
let publicAddress = thorAddress
const preTxs: EdgeTransaction[] = []
let memoType: EdgeMemo['type']
Expand Down Expand Up @@ -744,9 +743,6 @@ export function makeThorchainBasedPlugin(
)
assetAddress = sourceTokenContractAddress

// Token transactions send no ETH (or other EVM mainnet coin)
ethNativeAmount = '0'

const approvalTxs = await createEvmApprovalEdgeTransactions({
request,
approvalAmount: nativeAmount,
Expand Down Expand Up @@ -902,7 +898,13 @@ export function makeThorchainBasedPlugin(
],
spendTargets: [
{
nativeAmount: ethNativeAmount,
// The amount spent from the wallet, always denominated in the
// from-asset. For EVM token swaps this is the token amount even though
// the router contract call sends zero parent-currency value (the
// currency engine forces value to 0 for token contract calls). Using
// the token amount here keeps the pending transaction metadata
// (amount, fiat, percent) correct instead of showing 0.
nativeAmount: fromNativeAmount,
publicAddress
}
],
Expand Down
Loading